From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: "Mr. Charles Edward Lever" <Chuck.Lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Sunrpc transport reconnection...
Date: Mon, 29 Mar 2010 17:43:07 -0400 [thread overview]
Message-ID: <1269898987.15895.95.camel@localhost.localdomain> (raw)
Having looked more carefully at the code...
Is there any reason to keep the xprt->connect_timeout? As far as I can
see, it would appear to be completely redundant.
For UDP there is no disconnect/reconnect. The socket is set up once and
for all, so no need for connect_timeout.
In the case of a TCP reconnection, the xprt->reestablish_timeout will do
exponential back-off to prevent reconnecting unnecessarily. The
XPRT_CONNECTING lock then prevents anyone from trying to interfere with
that connect request until it gets a reply, or the TCP layer decides
that the socket has timed out. Again, it appears that
xprt->connect_timeout is redundant.
RDMA reconnection appears to follow the TCP model. Once again, there is
exponential back-off, enforced by XPRT_CONNECTING.
So why do we have xprt->connect_timeout? What is it enforcing?
Trond
next reply other threads:[~2010-03-29 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 21:43 Trond Myklebust [this message]
[not found] ` <1269898987.15895.95.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-29 22:25 ` Sunrpc transport reconnection Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269898987.15895.95.camel@localhost.localdomain \
--to=trond.myklebust@netapp.com \
--cc=Chuck.Lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox