From mboxrd@z Thu Jan  1 00:00:00 1970
From: Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: RCU-isms in fs/nfs/delegation.c
Date: Tue, 20 Apr 2010 08:29:06 -0400
Message-ID: <1271766546.25129.76.camel@localhost.localdomain>
References: <1271698361.13653.79.camel@localhost.localdomain>
	 <14317.1271691185@redhat.com>  <32174.1271753314@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: paulmck@linux.vnet.ibm.com, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: David Howells <dhowells@redhat.com>
Return-path: <linux-nfs-owner@vger.kernel.org>
Received: from mx2.netapp.com ([216.240.18.37]:19956 "EHLO mx2.netapp.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753953Ab0DTM30 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-nfs@vger.kernel.org>); Tue, 20 Apr 2010 08:29:26 -0400
In-Reply-To: <32174.1271753314@redhat.com>
Sender: linux-nfs-owner@vger.kernel.org
List-ID: <linux-nfs.vger.kernel.org>

On Tue, 2010-04-20 at 09:48 +0100, David Howells wrote: 
> Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> 
> > +		nfs_inode_set_delegation(inode, cred, res);
> > +	}
> > +out:
> > +	rcu_read_unlock();
> >  }
> 
> I think this is wrong.  nfs_inode_set_delegation() may sleep as it calls
> kmalloc() with GFP_KERNEL - but you still have the RCU read lock held.  I
> think you need to drop the RCU read lock before calling it.
> 
> David

Agreed. Thanks for the review...

Cheers
  Trond