linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: andros@netapp.com
To: bhalevy@panasas.com
Cc: iisaman@netapp.com, linux-nfs@vger.kernel.org,
	Andy Adamson <andros@netapp.com>
Subject: [PATCH 10/10] SQUASHME pnfs_submit: cleanup filelayout pg_test
Date: Wed, 12 May 2010 10:44:22 -0400	[thread overview]
Message-ID: <1273675462-15758-11-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1273675462-15758-10-git-send-email-andros@netapp.com>

From: Andy Adamson <andros@netapp.com>

pg_bsize is set in nfs_pageio_init.
Squash into: "pnfs:filelayout:pg_test"

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 fs/nfs/nfs4filelayout.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
index dfc5149..200bbc2 100644
--- a/fs/nfs/nfs4filelayout.c
+++ b/fs/nfs/nfs4filelayout.c
@@ -697,9 +697,6 @@ filelayout_get_stripesize(struct pnfs_layout_type *layoutid)
 /*
  * filelayout_pg_test(). Called by nfs_can_coalesce_requests()
  *
- * For writes which come from the flush daemon, set the bsize on the fly.
- * reads set the bsize in pnfs_pageio_init_read.
- *
  * return 1 :  coalesce page
  * return 0 :  don't coalesce page
  */
@@ -709,13 +706,6 @@ filelayout_pg_test(struct nfs_pageio_descriptor *pgio, struct nfs_page *prev,
 {
 	u64 p_stripe, r_stripe;
 
-	if (!pgio->pg_iswrite)
-		goto boundary;
-
-	if (pgio->pg_bsize != NFS_SERVER(pgio->pg_inode)->wsize)
-		pgio->pg_bsize = NFS_SERVER(pgio->pg_inode)->wsize;
-
-boundary:
 	if (pgio->pg_boundary == 0)
 		return 1;
 	p_stripe = (u64)prev->wb_index << PAGE_CACHE_SHIFT;
-- 
1.6.6


      reply	other threads:[~2010-05-12 14:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-12 14:44 (unknown), andros
2010-05-12 14:44 ` [PATCH 01/10] SQUASHME pnfs_submit: remove filelayout get threshold andros
2010-05-12 14:44   ` [PATCH 02/10] SQUASHME pnfs_submit: don't use pnfs_use_read andros
2010-05-12 14:44     ` [PATCH 03/10] SQUASHME pnfs_submit: don't use pnfs_use_write andros
2010-05-12 14:44       ` [PATCH 04/10] SQUASHME pnfs_submit: don't use pnfs_use_write for commit andros
2010-05-12 14:44         ` [PATCH 05/10] SQUASHME pnfs_submit: don't use pg_threshold andros
2010-05-12 14:44           ` [PATCH 06/10] SQUASHME pnfs_submit: remove pg_threshold andros
2010-05-12 14:44             ` [PATCH 07/10] SQUASHME pnfs_submit: don't use below_threshold in read andros
2010-05-12 14:44               ` [PATCH 08/10] SQUASHME pnfs_submit: don't use below_threshold in direct io andros
2010-05-12 14:44                 ` [PATCH 09/10] SQUASHME pnfs_submit: remove unused threshold calculations andros
2010-05-12 14:44                   ` andros [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273675462-15758-11-git-send-email-andros@netapp.com \
    --to=andros@netapp.com \
    --cc=bhalevy@panasas.com \
    --cc=iisaman@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).