From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Tao Guo <guotao-U4AKAne5IzAR5TUyvShJeg@public.gmane.org>
Cc: linux-nfs@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Benny Halevy <bhalevy@panasas.com>
Subject: Re: [PATCH] nfs: avoid possible deadlock bug when setting up delegation.
Date: Thu, 20 May 2010 09:47:15 -0400 [thread overview]
Message-ID: <1274363235.2949.4.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <AANLkTilrfrlhyJ7G8jy6X9emrGIGnEAxFjqlYns8K0OT-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 2010-05-20 at 21:20 +0800, Tao Guo wrote:
> On Thu, May 20, 2010 at 8:57 PM, Trond Myklebust
> <trond.myklebust@fys.uio.no> wrote:
> > On Thu, 2010-05-20 at 13:42 +0800, Tao Guo wrote:
> >> Unlock clp->cl_lock before taking inode->i_lock when setting up
> >> delegation to avoid possible deadlock bug.
> >
> > What deadlock? inode->i_lock should always be the innermost lock, so it
> > should always be safe to take it while already holding the nfs_client
> > lock.
> here is: http://marc.info/?l=linux-nfs&m=127424502009958&w=2
> >
That would be a pnfs bug... Please fix it so that it adheres to the
locking rules in mainline.
Trond
prev parent reply other threads:[~2010-05-20 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 5:42 [PATCH] nfs: avoid possible deadlock bug when setting up delegation Tao Guo
2010-05-20 12:57 ` Trond Myklebust
[not found] ` <1274360236.2949.1.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2010-05-20 13:20 ` Tao Guo
[not found] ` <AANLkTilrfrlhyJ7G8jy6X9emrGIGnEAxFjqlYns8K0OT-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-20 13:47 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274363235.2949.4.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=guotao-U4AKAne5IzAR5TUyvShJeg@public.gmane.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).