From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] sunrpc: fix leak on error on socket xprt setup
Date: Fri, 21 May 2010 09:16:19 -0400 [thread overview]
Message-ID: <1274447779.3692.8.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20100521002508.GA30928@fieldses.org>
On Thu, 2010-05-20 at 20:25 -0400, J. Bruce Fields wrote:
> From: J. Bruce Fields <bfields@citi.umich.edu>
>
> Also collect exit code together while we're at it.
>
> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
> net/sunrpc/xprtsock.c | 29 ++++++++++++++++++-----------
> 1 files changed, 18 insertions(+), 11 deletions(-)
>
> I think I sent this before, but it must have fallen through the cracks.
The patch doesn't really ring a bell, but it looks correct. On the other
hand, this doesn't look like a bug we'd ever hit in practice, so I'll
probably delay merging it until I've got a few more critical bugfixes
queued up.
Unless, of course, you'd prefer to merge it yourself?
Cheers
Trond
next prev parent reply other threads:[~2010-05-21 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 0:25 [PATCH] sunrpc: fix leak on error on socket xprt setup J. Bruce Fields
2010-05-21 13:16 ` Trond Myklebust [this message]
[not found] ` <1274447779.3692.8.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2010-05-21 15:12 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274447779.3692.8.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).