From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: nfs_access_cache_shrinker() is missing an unlock
Date: Wed, 26 May 2010 08:34:33 -0400 [thread overview]
Message-ID: <1274877273.5270.6.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <2068.1274876574@redhat.com>
On Wed, 2010-05-26 at 13:22 +0100, David Howells wrote:
> Hi Trond,
>
> nfs_access_cache_shrinker() incurs the attached lockdep warning and then locks
> up.
>
> Specifically, the problem appears to be the:
>
> spin_lock(&inode->i_lock);
>
> in the loop, for which there's not an unlock. Nor is there an unlock in
> nfs_access_free_list() or nfs_access_free_entry.
>
> Is the spin_unlock() supposed to occur at the end of the loop, just before the
> closing brace? Or did you mean to defer the unlock to nfs_access_free_entry()?
Oh, crap... That's a typo in commit
9c7e7e23371e629dbb3b341610a418cdf1c19d91. I did not intend to remove the
spin_unlock(&inode->i_lock) line.
Thanks for spotting that!
Trond
prev parent reply other threads:[~2010-05-26 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 12:22 nfs_access_cache_shrinker() is missing an unlock David Howells
2010-05-26 12:34 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274877273.5270.6.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).