From: "J. Bruce Fields" <bfields@citi.umich.edu>
To: Benny Halevy <bhalevy@panasas.com>
Cc: linux-nfs@vger.kernel.org, Eric Anderle <eanderle@umich.edu>,
"J. Bruce Fields" <bfields@citi.umich.edu>
Subject: [PATCH 2/2] pnfsd: fix test in nfsd4_find_pnfs_dlm_device
Date: Fri, 28 May 2010 13:15:21 -0400 [thread overview]
Message-ID: <1275066921-29335-2-git-send-email-bfields@citi.umich.edu> (raw)
In-Reply-To: <1275066921-29335-1-git-send-email-bfields@citi.umich.edu>
From: Eric Anderle <eanderle@umich.edu>
This test is obviously backwards. Noticed because pnfs_dlm_device was
allowing us to re-add the same disk multiple times.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---
fs/nfsd/nfs4pnfsdlm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4pnfsdlm.c b/fs/nfsd/nfs4pnfsdlm.c
index 0351d71..1cf1b69 100644
--- a/fs/nfsd/nfs4pnfsdlm.c
+++ b/fs/nfsd/nfs4pnfsdlm.c
@@ -53,7 +53,7 @@ nfsd4_find_pnfs_dlm_device(char *disk_name)
spin_lock(&dlm_device_list_lock);
list_for_each_entry(dlm_pdev, &dlm_device_list, dlm_dev_list) {
- if (memcmp(dlm_pdev->disk_name, disk_name, strlen(disk_name))) {
+ if (!memcmp(dlm_pdev->disk_name, disk_name, strlen(disk_name))) {
spin_unlock(&dlm_device_list_lock);
return dlm_pdev;
}
--
1.7.0.4
next prev parent reply other threads:[~2010-05-28 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 17:15 [PATCH 1/2] pnfsd: make /proc/fs/nfsd/pnfs_dlm_device report dlm device list J. Bruce Fields
2010-05-28 17:15 ` J. Bruce Fields [this message]
2010-05-28 17:20 ` [PATCH 2/2] pnfsd: fix test in nfsd4_find_pnfs_dlm_device J. Bruce Fields
2010-06-01 4:36 ` Benny Halevy
2010-06-01 4:36 ` [PATCH 1/2] pnfsd: make /proc/fs/nfsd/pnfs_dlm_device report dlm device list Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275066921-29335-2-git-send-email-bfields@citi.umich.edu \
--to=bfields@citi.umich.edu \
--cc=bhalevy@panasas.com \
--cc=eanderle@umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).