From: Fred Isaman <iisaman@netapp.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 2/7] SQUASHME: pnfsblock: write_begin adjust for removed fields
Date: Fri, 11 Jun 2010 03:40:34 -0400 [thread overview]
Message-ID: <1276242039-18649-3-git-send-email-iisaman@netapp.com> (raw)
In-Reply-To: <1276242039-18649-2-git-send-email-iisaman@netapp.com>
ok_to_use_pnfs and PG_USE_PNFS are gone, instead test req->wb_lseg for NULL.
This also means that the entire do_flush routine is redundant.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
---
fs/nfs/blocklayout/blocklayout.c | 21 ++++-----------------
1 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
index 66044d4..eb5760f 100644
--- a/fs/nfs/blocklayout/blocklayout.c
+++ b/fs/nfs/blocklayout/blocklayout.c
@@ -988,10 +988,10 @@ bl_write_begin(struct pnfs_layout_segment *lseg, struct page *page, loff_t pos,
if (bl->bl_blocksize < (PAGE_CACHE_SIZE >> 9)) {
dprintk("%s Can't handle blocksize %llu\n", __func__,
(u64)bl->bl_blocksize);
- fsdata->ok_to_use_pnfs = 0;
+ put_lseg(fsdata->lseg);
+ fsdata->lseg = NULL;
return 0;
}
- fsdata->ok_to_use_pnfs = 1;
if (PageMappedToDisk(page)) {
/* Basically, this is a flag that says we have
* successfully called write_begin already on this page.
@@ -1014,7 +1014,8 @@ bl_write_begin(struct pnfs_layout_segment *lseg, struct page *page, loff_t pos,
* should be true if we get here.
*/
BUG_ON(PagePrivate(page));
- fsdata->ok_to_use_pnfs = 0;
+ put_lseg(fsdata->lseg);
+ fsdata->lseg = NULL;
kfree(pages_to_mark);
ret = 0;
} else {
@@ -1122,19 +1123,6 @@ bl_pg_test(struct nfs_pageio_descriptor *pgio, struct nfs_page *prev,
}
}
-/* This checks if old req will likely use same io method as soon
- * to be created request, and returns False if they are the same.
- */
-static int
-bl_do_flush(struct pnfs_layout_segment *lseg, struct nfs_page *req,
- struct pnfs_fsdata *fsdata)
-{
- int will_try_pnfs;
- dprintk("%s enter\n", __func__);
- will_try_pnfs = fsdata ? (fsdata->ok_to_use_pnfs) : (lseg != NULL);
- return will_try_pnfs != test_bit(PG_USE_PNFS, &req->wb_flags);
-}
-
static struct layoutdriver_io_operations blocklayout_io_operations = {
.commit = bl_commit,
.read_pagelist = bl_read_pagelist,
@@ -1156,7 +1144,6 @@ static struct layoutdriver_io_operations blocklayout_io_operations = {
static struct layoutdriver_policy_operations blocklayout_policy_operations = {
.get_stripesize = bl_get_stripesize,
.pg_test = bl_pg_test,
- .do_flush = bl_do_flush,
};
static struct pnfs_layoutdriver_type blocklayout_type = {
--
1.6.6.1
next prev parent reply other threads:[~2010-06-11 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 7:40 [PATCH 0/7] LAYOUTGET invocation cleanup patches Fred Isaman
2010-06-11 7:40 ` [PATCH 1/7] SQUASHME: pnfs: export get_lseg and put_lseg Fred Isaman
2010-06-11 7:40 ` Fred Isaman [this message]
2010-06-11 7:40 ` [PATCH 3/7] SQUASHME: pnfsblock: write_end adjust for removed ok_to_use_pnfs Fred Isaman
2010-06-11 7:40 ` [PATCH 4/7] SQUASHME: pnfsblock: write_end_cleanup " Fred Isaman
2010-06-11 7:40 ` [PATCH 5/7] SQUASHME: pnfsblock: bl_write_pagelist support functions adjust for missing PG_USE_PNFS Fred Isaman
2010-06-11 7:40 ` [PATCH 6/7] SQUASHME: pnfsblock: bl_write_pagelist " Fred Isaman
2010-06-11 7:40 ` [PATCH 7/7] pnfs: Revert "pnfs_post_submit: Restore "pnfs: pnfs_do_flush" part 2" Fred Isaman
2010-06-11 8:07 ` [PATCH 0/7] LAYOUTGET invocation cleanup patches Boaz Harrosh
2010-06-11 8:47 ` Fred Isaman
2010-06-11 8:58 ` Boaz Harrosh
2010-06-11 13:44 ` Fred Isaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276242039-18649-3-git-send-email-iisaman@netapp.com \
--to=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox