public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org,
	chris-TF6qbakwsgc2epGFuHBODCp2UmYkHbXO@public.gmane.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] nfsd: make sure all sv_permsocks have lockd references
Date: Thu, 17 Jun 2010 10:17:45 -0400	[thread overview]
Message-ID: <1276784267-28500-1-git-send-email-jlayton@redhat.com> (raw)

This patchset should apply cleanly to the other patches that I've sent
recently. They fix some (theoretical) problems with the text-based write
ports and nfsd_init_socks interfaces.

The problem is that nfsd_last_thread expects that every socket on
sv_permsocks has a corresponding lockd reference, but there a couple of
ways to get sockets onto that list without getting a lockd reference.

This patch fixes all that I could spot. I suspect that this, along with
the other patches that I proposed earlier will fix the problem that
Chris Vine reported.

I've done some basic smoke testing with them and they seem to work
as expected.

I've also put the entire patch stack in my git tree on kernel.org:

http://git.kernel.org/?p=linux/kernel/git/jlayton/linux.git;a=summary

...in the nfsd-error branch. It may be more convenient to pull them
from there.

Jeff Layton (2):
  nfsd: shut down transport in nfsd_init_socks if no lockd reference
  nfsd: have __write_ports_add/delxprt get/put lockd references for
    transports

 fs/nfsd/nfsctl.c |   59 ++++++++++++++++++++++++++++++++++++++---------------
 fs/nfsd/nfssvc.c |   21 +++++++++++++++---
 2 files changed, 59 insertions(+), 21 deletions(-)


             reply	other threads:[~2010-06-17 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 14:17 Jeff Layton [this message]
2010-06-17 14:17 ` [PATCH] nfsd: shut down transport in nfsd_init_socks if no lockd reference Jeff Layton
2010-06-17 14:17 ` [PATCH] nfsd: have __write_ports_add/delxprt get/put lockd references for transports Jeff Layton
2010-06-17 14:37   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276784267-28500-1-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=chris-TF6qbakwsgc2epGFuHBODCp2UmYkHbXO@public.gmane.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox