* [PATCH] SQUASHME: pnfs-block: nfs4_blk_add_block_disk ret must be signed
@ 2010-06-29 12:06 Benny Halevy
0 siblings, 0 replies; only message in thread
From: Benny Halevy @ 2010-06-29 12:06 UTC (permalink / raw)
To: linux-nfs
otherwise checking for ret < 0 is futile.
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
fs/nfs/blocklayout/blocklayoutdev.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/blocklayout/blocklayoutdev.c b/fs/nfs/blocklayout/blocklayoutdev.c
index ef39c36..a866f5c 100644
--- a/fs/nfs/blocklayout/blocklayoutdev.c
+++ b/fs/nfs/blocklayout/blocklayoutdev.c
@@ -105,7 +105,8 @@ nfs4_blk_add_block_disk(struct device *cdev,
static char *claim_ptr = "I belong to pnfs block driver";
struct block_device *bdev;
struct gendisk *gd;
- unsigned int major, minor, ret = 0;
+ unsigned int major, minor;
+ int ret;
dev_t dev;
dprintk("%s enter \n", __func__);
--
1.6.6.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-29 12:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-29 12:06 [PATCH] SQUASHME: pnfs-block: nfs4_blk_add_block_disk ret must be signed Benny Halevy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).