From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Jeff Layton <jlayton@redhat.com>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: prevent task_cleanup running on freed xprt
Date: Tue, 03 Aug 2010 17:32:22 -0400 [thread overview]
Message-ID: <1280871142.14520.7.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20100803212220.GI31579@fieldses.org>
On Tue, 2010-08-03 at 17:22 -0400, J. Bruce Fields wrote:
> From: J. Bruce Fields <bfields@redhat.com>
>
> We saw a report of a NULL dereference in xprt_autoclose:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=611938
>
> This appears to be the result of an xprt's task_cleanup running after
> the xprt is destroyed. Nothing in the current code appears to prevent
> that.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
Thanks. Applied to nfs-for-2.6.36...
Trond
next prev parent reply other threads:[~2010-08-03 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 17:24 sunrpc: what prevents an xprt from being freed before task_cleanup runs? Jeff Layton
2010-08-03 18:40 ` Trond Myklebust
2010-08-03 18:48 ` J. Bruce Fields
2010-08-03 18:56 ` Trond Myklebust
2010-08-03 19:18 ` J. Bruce Fields
2010-08-03 18:49 ` Trond Myklebust
2010-08-03 21:22 ` [PATCH] SUNRPC: prevent task_cleanup running on freed xprt J. Bruce Fields
2010-08-03 21:32 ` Trond Myklebust [this message]
2010-08-03 18:59 ` sunrpc: what prevents an xprt from being freed before task_cleanup runs? Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280871142.14520.7.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).