From: Benny Halevy <bhalevy@panasas.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org, Benny Halevy <bhalevy@panasas.com>
Subject: [PATCH 2/4] sunrpc: clean up xdr_shrink_pagelen use of temporary pointer
Date: Wed, 18 Aug 2010 23:42:48 +0300 [thread overview]
Message-ID: <1282164168-20318-1-git-send-email-bhalevy@panasas.com> (raw)
In-Reply-To: <4C6C4565.1070603@panasas.com>
char *p is used only as a shorthand for tail->iov_base + len in a nested
block. Move it there.
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
net/sunrpc/xdr.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index 91f0de9..41be21f 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -395,7 +395,6 @@ xdr_shrink_pagelen(struct xdr_buf *buf, size_t len)
{
struct kvec *tail;
size_t copy;
- char *p;
unsigned int pglen = buf->page_len;
tail = buf->tail;
@@ -403,8 +402,8 @@ xdr_shrink_pagelen(struct xdr_buf *buf, size_t len)
/* Shift the tail first */
if (tail->iov_len != 0) {
- p = (char *)tail->iov_base + len;
if (tail->iov_len > len) {
+ char *p = (char *)tail->iov_base + len;
copy = tail->iov_len - len;
memmove(p, tail->iov_base, copy);
}
--
1.7.2.1
next prev parent reply other threads:[~2010-08-18 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 20:41 [PATCH 0/4] fix up xdr_shrink_pagelen Benny Halevy
2010-08-18 20:42 ` [PATCH 1/4] sunrpc: don't shorten buflen twice in xdr_shrink_pagelen Benny Halevy
2010-08-18 21:26 ` Trond Myklebust
2010-08-18 22:16 ` Trond Myklebust
2010-08-19 5:49 ` Benny Halevy
2010-08-18 20:42 ` Benny Halevy [this message]
2010-08-18 20:42 ` [PATCH 3/4] sunrpc: don't use the copy variable in nested block Benny Halevy
2010-08-18 20:43 ` [PATCH 4/4] sunrpc: simplify xdr_shrijk_pagelen use of "copy" Benny Halevy
2010-08-18 21:19 ` Trond Myklebust
2010-08-19 5:39 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282164168-20318-1-git-send-email-bhalevy@panasas.com \
--to=bhalevy@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).