From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: NFS writes broken in net-next-2.6
Date: Wed, 08 Sep 2010 21:14:10 +0100 [thread overview]
Message-ID: <1283976850.2237.9.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <20100908.130550.115952209.davem@davemloft.net>
On Wed, 2010-09-08 at 13:05 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Wed, 08 Sep 2010 21:01:08 +0100
>
> > In net-next-2.6, close() of a file after writing tends to return 1.
> > This causes e.g. gcc to abort.
> >
> > This appears to have been fixed in 2.6.36-rc2:
> >
> > commit 0702099bd86c33c2dcdbd3963433a61f3f503901
> > Author: J. R. Okajima <hooanon05@yahoo.co.jp>
> > Date: Wed Aug 11 13:10:16 2010 -0400
> >
> > NFS: fix the return value of nfs_file_fsync()
> >
> > Please consider merging this fix in some way.
>
> Ben, and please I've told you this before,
I don't think so.
> if you need a specific
> upstream fix do your testing on a branch that pulls in Linus's tree
> or, alternatively, apply the fix you need by hand using "git stash" or
> similar.
[...]
Sure, that's what I'm doing. But this is likely to hit more developers
than just me.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2010-09-08 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 20:01 NFS writes broken in net-next-2.6 Ben Hutchings
2010-09-08 20:05 ` David Miller
2010-09-08 20:14 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283976850.2237.9.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox