From: Fred Isaman <iisaman@netapp.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 1/4] pnfs_submit: Remove nonsensical check
Date: Wed, 6 Oct 2010 16:35:14 -0400 [thread overview]
Message-ID: <1286397317-17881-2-git-send-email-iisaman@netapp.com> (raw)
In-Reply-To: <1286397317-17881-1-git-send-email-iisaman@netapp.com>
Only a buggy server would return a zero iomode with roc set.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
---
fs/nfs/pnfs.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 4b33cde..39bce9b 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -935,12 +935,8 @@ pnfs_layout_process(struct nfs4_layoutget *lgp)
/* FI: This needs to be re-examined. At lo level,
* all it needs is a bit indicating whether any of
* the lsegs in the list have the flags set.
- *
- * The IOMODE_ANY line just seems nonsensical.
*/
lo->roc_iomode |= res->range.iomode;
- if (!lo->roc_iomode)
- lo->roc_iomode = IOMODE_ANY;
}
/* Done processing layoutget. Set the layout stateid */
--
1.7.2.1
next prev parent reply other threads:[~2010-10-07 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 20:35 [PATCH 0/4] pnfs-submit: misc fixes in CB_LAYOUTRECALL and layout stateid code Fred Isaman
2010-10-06 20:35 ` Fred Isaman [this message]
2010-10-06 20:35 ` [PATCH 2/4] pnfs_submit: Only update stateid if it is more recent than current Fred Isaman
2010-10-07 13:34 ` Benny Halevy
2010-10-07 14:01 ` Fred Isaman
2010-10-07 14:06 ` Benny Halevy
2010-10-08 14:13 ` P.B.Shelley
2010-10-08 14:16 ` Benny Halevy
2010-10-08 14:35 ` Fred Isaman
2010-10-08 15:36 ` P.B.Shelley
2010-10-08 15:52 ` Fred Isaman
2010-10-06 20:35 ` [PATCH 3/4] pnfs_submit: simplify nfs4_callback_layoutrecall Fred Isaman
2010-10-06 20:35 ` [PATCH 4/4] pnfs_submit: Fix clp refcounting in layout recalls Fred Isaman
2010-10-07 15:32 ` [PATCH 0/4] pnfs-submit: misc fixes in CB_LAYOUTRECALL and layout stateid code Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286397317-17881-2-git-send-email-iisaman@netapp.com \
--to=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).