From: Benny Halevy <bhalevy@panasas.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 2/2] SQUASHME: pnfs: get_lseg in nfs4_layoutget_prepare rather than in pnfs_has_layout
Date: Thu, 7 Oct 2010 15:17:58 -0400 [thread overview]
Message-ID: <1286479078-29072-1-git-send-email-bhalevy@panasas.com> (raw)
In-Reply-To: <4CAE16FA.9040606@panasas.com>
pnfs_has_layout does not get_lref on its return value anymore
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
fs/nfs/nfs4proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 25bc169..97cc539 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5442,12 +5442,12 @@ nfs4_layoutget_prepare(struct rpc_task *task, void *calldata)
return;
}
if (!lseg->valid) {
- put_lseg_locked(lseg);
spin_unlock(&ino->i_lock);
dprintk("%s: invalid lseg found, waiting\n", __func__);
rpc_sleep_on(&nfsi->lo_rpcwaitq, task, NULL);
return;
}
+ get_lseg(lseg);
*lgp->lsegpp = lseg;
spin_unlock(&ino->i_lock);
dprintk("%s: valid lseg found, no rpc required\n", __func__);
--
1.7.2.3
next prev parent reply other threads:[~2010-10-07 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 19:37 [PATCH 1/3] pnfs_submit: move layout segment valid test andros
2010-10-07 18:52 ` Benny Halevy
2010-10-07 19:17 ` [PATCH 1/1] SQUASHME: pnfs-submit: do not get_lseg in pnfs_has_layout Benny Halevy
2010-10-07 19:17 ` Benny Halevy [this message]
2010-10-07 19:28 ` [PATCH 1/3] pnfs_submit: move layout segment valid test William A. (Andy) Adamson
2010-10-07 19:37 ` [PATCH 2/3] pnfs_submit: fix deadlock in pnfs_clear_lseg_list andros
2010-10-07 19:37 ` [PATCH 3/3] pnfs_submit: enforce requested DS only pNFS role andros
2010-10-07 17:06 ` Benny Halevy
2010-10-07 18:08 ` Benny Halevy
2010-10-07 18:41 ` Benny Halevy
2010-10-07 19:23 ` Benny Halevy
2010-10-07 18:10 ` Fred Isaman
2010-10-07 18:12 ` Fred Isaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286479078-29072-1-git-send-email-bhalevy@panasas.com \
--to=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).