From: Jeff Layton <jlayton@redhat.com>
To: steved@redhat.com
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org
Subject: [PATCH] nfs-utils: fix default value for --enable-tirpc
Date: Mon, 11 Oct 2010 21:29:51 -0400 [thread overview]
Message-ID: <1286846991-4876-1-git-send-email-jlayton@redhat.com> (raw)
The patch I originally proposed to make --enable-tirpc the default had
the default for $enable_tirpc as a blank string. When it was merged
however, that value was changed to a 'yes'. This broke the ability for
autoconf to detect and autodisable building with tirpc. When tirpc isn't
present now, the configure step fails unless someone explicitly
specifies --disable-libtirpc.
We need $enable_tirpc to be a tristate. 'yes' means that someone
explicitly requested building with tirpc. 'no' means that it was
explicitly disabled. Anything else means that no one specified a value.
Fix it by setting the value to a blank string so that the default is
properly undefined.
Reported-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
configure.ac | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3058be6..5408e85 100644
--- a/configure.ac
+++ b/configure.ac
@@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
[AC_HELP_STRING([--enable-tirpc],
[enable use of TI-RPC @<:@default=yes@:>@])],
enable_tirpc=$enableval,
- enable_tirpc='yes')
+ enable_tirpc='')
AC_ARG_ENABLE(ipv6,
[AC_HELP_STRING([--enable-ipv6],
[enable support for IPv6 @<:@default=no@:>@])],
--
1.7.1
next reply other threads:[~2010-10-12 1:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 1:29 Jeff Layton [this message]
2010-10-12 17:44 ` [PATCH] nfs-utils: fix default value for --enable-tirpc J. Bruce Fields
2010-10-28 13:24 ` Steve Dickson
2010-10-28 13:38 ` Jeff Layton
2010-10-28 14:03 ` Steve Dickson
2010-11-01 12:11 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286846991-4876-1-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).