* [PATCH -next] nfs: include ratelimit.h, fix nfs4state build error [not found] <20101022152350.fc79e2b9.sfr@canb.auug.org.au> @ 2010-10-22 23:18 ` Randy Dunlap 2010-10-23 14:09 ` Trond Myklebust 0 siblings, 1 reply; 2+ messages in thread From: Randy Dunlap @ 2010-10-22 23:18 UTC (permalink / raw) To: Stephen Rothwell, Trond Myklebust, akpm; +Cc: linux-next, LKML, linux-nfs From: Randy Dunlap <randy.dunlap@oracle.com> nfs4state.c uses interfaces from ratelimit.h. It needs to include that header file to fix build errors: fs/nfs/nfs4state.c:1195: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' fs/nfs/nfs4state.c:1195: warning: parameter names (without types) in function declaration fs/nfs/nfs4state.c:1195: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE' fs/nfs/nfs4state.c:1195: error: implicit declaration of function '__ratelimit' fs/nfs/nfs4state.c:1195: error: '_rs' undeclared (first use in this function) Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Trond Myklebust <Trond.Myklebust@netapp.com> Cc: linux-nfs@vger.kernel.org --- fs/nfs/nfs4state.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20101022.orig/fs/nfs/nfs4state.c +++ linux-next-20101022/fs/nfs/nfs4state.c @@ -46,6 +46,7 @@ #include <linux/kthread.h> #include <linux/module.h> #include <linux/random.h> +#include <linux/ratelimit.h> #include <linux/workqueue.h> #include <linux/bitops.h> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] nfs: include ratelimit.h, fix nfs4state build error 2010-10-22 23:18 ` [PATCH -next] nfs: include ratelimit.h, fix nfs4state build error Randy Dunlap @ 2010-10-23 14:09 ` Trond Myklebust 0 siblings, 0 replies; 2+ messages in thread From: Trond Myklebust @ 2010-10-23 14:09 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, akpm, linux-next, LKML, linux-nfs On Fri, 2010-10-22 at 16:18 -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > nfs4state.c uses interfaces from ratelimit.h. It needs to include > that header file to fix build errors: > > fs/nfs/nfs4state.c:1195: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' > fs/nfs/nfs4state.c:1195: warning: parameter names (without types) in function declaration > fs/nfs/nfs4state.c:1195: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE' > fs/nfs/nfs4state.c:1195: error: implicit declaration of function '__ratelimit' > fs/nfs/nfs4state.c:1195: error: '_rs' undeclared (first use in this function) > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Trond Myklebust <Trond.Myklebust@netapp.com> > Cc: linux-nfs@vger.kernel.org > --- > fs/nfs/nfs4state.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20101022.orig/fs/nfs/nfs4state.c > +++ linux-next-20101022/fs/nfs/nfs4state.c > @@ -46,6 +46,7 @@ > #include <linux/kthread.h> > #include <linux/module.h> > #include <linux/random.h> > +#include <linux/ratelimit.h> > #include <linux/workqueue.h> > #include <linux/bitops.h> > That one is my fault. Sorry, and thanks Randy! I've applied the fix to the linux-next branch... Cheers Trond ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-23 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20101022152350.fc79e2b9.sfr@canb.auug.org.au>
2010-10-22 23:18 ` [PATCH -next] nfs: include ratelimit.h, fix nfs4state build error Randy Dunlap
2010-10-23 14:09 ` Trond Myklebust
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).