From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: wharms@bfs.de
Cc: Dan Carpenter <error27@gmail.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] nfs: check kmalloc() return
Date: Thu, 28 Oct 2010 09:41:13 -0400 [thread overview]
Message-ID: <1288273273.3194.16.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <4CC92338.7070304@bfs.de>
On Thu, 2010-10-28 at 09:16 +0200, walter harms wrote:
>
> Dan Carpenter schrieb:
> > The decode_and_add_ds() should return NULL on failure.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/fs/nfs/nfs4filelayoutdev.c b/fs/nfs/nfs4filelayoutdev.c
> > index 51fe64a..098113c 100644
> > --- a/fs/nfs/nfs4filelayoutdev.c
> > +++ b/fs/nfs/nfs4filelayoutdev.c
> > @@ -219,6 +219,8 @@ decode_and_add_ds(__be32 **pp, struct inode *inode)
> > goto out_err;
> > }
> > buf = kmalloc(rlen + 1, GFP_KERNEL);
> > + if (!buf)
> > + goto out_err;
> > buf[rlen] = '\0';
> > memcpy(buf, r_addr, rlen);
> >
>
> it seems that r_addr is a string, then kstdup() is emulated here.
>
> re,
> wh
Not quite. kstrdup() requires that the argument be a NUL-terminated
string. The above code doesn't.
Trond
next prev parent reply other threads:[~2010-10-28 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 4:44 [patch] nfs: check kmalloc() return Dan Carpenter
2010-10-28 7:16 ` walter harms
2010-10-28 13:41 ` Trond Myklebust [this message]
2010-10-28 14:14 ` Benny Halevy
2010-10-28 16:57 ` Dan Carpenter
2010-10-29 7:33 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288273273.3194.16.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).