linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Ian Kent <raven@themaw.net>
Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk,
	linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org,
	linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Add a dentry op to handle automounting rather than abusing follow_link() [ver #2]
Date: Tue, 27 Jul 2010 09:48:41 +0100	[thread overview]
Message-ID: <12883.1280220521@redhat.com> (raw)
In-Reply-To: <1280202225.2944.20.camel@localhost>

Ian Kent <raven@themaw.net> wrote:

> Is this something others need?

Not as far as I know...  I think autofs is the only one doing out-of-kernel
automounting.

That doesn't mean it shouldn't be provided, though...

> Again, the exists vs not yet exists case for paths within indirect
> autofs mounts. At the moment I can just set the flag on all dentrys in
> the autofs fs and return EXDEV for non-empty directories in order to
> return the dentry as a path component. OTOH if the dentry is a mount
> embeded in the path and the mount fails we get a error return.

Seems redundant, but I'd say go with it for now.  Maybe we can offload
S_AUTOMOUNT to the dentry.

> I could clear the flag on non-root parent dentrys during mkdir if this
> is needed by others.

I'm not sure that would actually matter, since it would come to
follow_automount() at the same place.

Note that someone who tries to stat() with AT_NO_AUTOMOUNT will cause the call
to d_automount() to be suppressed and will see the negative or non-mounted
directory.  That might be okay for you.

David

  parent reply	other threads:[~2010-07-27  8:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 17:58 [PATCH 1/6] Add a dentry op to handle automounting rather than abusing follow_link() David Howells
2010-07-22 17:58 ` [PATCH 2/6] AFS: Use d_automount() " David Howells
2010-07-22 17:58 ` [PATCH 3/6] NFS: " David Howells
2010-07-22 17:59 ` [PATCH 4/6] CIFS: " David Howells
2010-07-22 17:59 ` [PATCH 5/6] Remove the automount through follow_link() kludge code from pathwalk David Howells
2010-07-22 17:59 ` [PATCH 6/6] Add an AT_NO_AUTOMOUNT flag to suppress terminal automount David Howells
2010-07-22 18:01 ` David Howells
2010-07-23 15:09 ` [PATCH 1/6] Add a dentry op to handle automounting rather than abusing follow_link() [ver #2] David Howells
2010-07-24  4:11   ` Ian Kent
2010-07-26 14:19   ` David Howells
2010-07-26 15:22     ` Ian Kent
2010-07-26 15:54     ` David Howells
2010-07-27  3:43       ` Ian Kent
2010-07-27  8:48       ` David Howells [this message]
2010-07-27 12:51         ` Ian Kent
     [not found] ` <20100722175913.5552.3905.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2010-07-23 15:11   ` [PATCH 6/6] Add an AT_NO_AUTOMOUNT flag to suppress terminal automount " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12883.1280220521@redhat.com \
    --to=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=raven@themaw.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).