From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Andy Adamson <andros@netapp.com>
Cc: Fred Isaman <iisaman@netapp.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/6] NFSv4.1: Callback share session between ops
Date: Thu, 28 Oct 2010 17:31:07 -0400 [thread overview]
Message-ID: <1288301467.14221.32.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <9E0EAD33-34BB-4284-95E9-16CDC6EB0484@netapp.com>
On Thu, 2010-10-28 at 16:18 -0400, Andy Adamson wrote:
> On Oct 28, 2010, at 3:35 PM, Trond Myklebust wrote:
>
> > On Thu, 2010-10-28 at 15:09 -0400, Fred Isaman wrote:
> >> From: Andy Adamson <andros@netapp.com>
> >>
> >> The NFSv4.1 session found in cb_sequence needs to be shared by other
> >> callback operations in the same cb_compound.
> >> Hold a reference to the session's nfs_client throughout the
> >> cb_compound
> >> processing.
> >
> > Wait... That isn't holding a reference. This patch ends up just
> > taking a
> > pointer.
>
> See comments in line. cb_sequence gets a reference to nfs_client and
> it's (for nfsv4.1) held until nfs4_callback_compound is done
> processing the compound.
Yes, but that doesn't offer you any guarantee that the nfs_client still
exists when you get to cb_sequence.
> > What guarantees that the session+nfs_client won't die on you
> > while you're processing the callback? Do we wait for callbacks to
> > finish
> > before closing the session?
>
> I think so. I'll look.
It seems to me that is a "must have" requirement.
Cheers
Trond
prev parent reply other threads:[~2010-10-28 21:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 19:09 [PATCH 1/6] NFSv4.1: Callback share session between ops Fred Isaman
2010-10-28 19:09 ` [PATCH 2/6] pnfs-submit: change pnfs_layout_segment refcounting from kref to atomic_t Fred Isaman
2010-10-28 19:09 ` [PATCH 3/6] pnfs-submit: remove _pnfs_can_return_lseg call from pnfs_clear_lseg_list Fred Isaman
2010-10-28 19:09 ` [PATCH 4/6] pnfs-submit: change layout state seqlock to a spinlock Fred Isaman
2010-10-28 19:10 ` [PATCH 5/6] pnfs-submit: nfs4_layoutreturn_release would crash on a bulk return Fred Isaman
2010-10-28 19:10 ` [PATCH 6/6] pnfs_submit: fix layoutreturn layout stateid processing Fred Isaman
2010-10-28 19:35 ` [PATCH 1/6] NFSv4.1: Callback share session between ops Trond Myklebust
2010-10-28 20:18 ` Andy Adamson
2010-10-28 21:31 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288301467.14221.32.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=andros@netapp.com \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).