linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fred Isaman <iisaman@netapp.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 08/22] SQUASHME: allow cb_sequence changes to compile without v4.1
Date: Fri, 12 Nov 2010 03:48:30 -0500	[thread overview]
Message-ID: <1289551724-18575-9-git-send-email-iisaman@netapp.com> (raw)
In-Reply-To: <1289551724-18575-1-git-send-email-iisaman@netapp.com>

Signed-off-by: Fred Isaman <iisaman@netapp.com>
---
 fs/nfs/callback.h      |   26 ++++++++++++++++++++++++++
 fs/nfs/callback_proc.c |    6 ------
 fs/nfs/callback_xdr.c  |    3 +--
 fs/nfs/internal.h      |    4 ++++
 4 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/fs/nfs/callback.h b/fs/nfs/callback.h
index 89fee05..0b1f3c4 100644
--- a/fs/nfs/callback.h
+++ b/fs/nfs/callback.h
@@ -8,6 +8,8 @@
 #ifndef __LINUX_FS_NFS_CALLBACK_H
 #define __LINUX_FS_NFS_CALLBACK_H
 
+#include "internal.h"
+
 #define NFS4_CALLBACK 0x40000000
 #define NFS4_CALLBACK_XDRSIZE 2048
 #define NFS4_CALLBACK_BUFSIZE (1024 + NFS4_CALLBACK_XDRSIZE)
@@ -158,6 +160,30 @@ extern unsigned nfs4_callback_layoutrecall(
 	struct cb_layoutrecallargs *args,
 	void *dummy, struct cb_process_state *cps);
 
+static inline void put_session_client(struct nfs4_session *session)
+{
+	if (session)  /* matched by cb_sequence find_client_with_session */
+		nfs_put_client(session->clp);
+}
+
+static inline struct nfs_client *
+find_client_from_cps(struct cb_process_state *cps, struct sockaddr *addr)
+{
+	return cps->session ? cps->session->clp : nfs_find_client(addr, 4);
+}
+
+#else
+
+static inline struct nfs_client *
+find_client_from_cps(struct cb_process_state *cps, struct sockaddr *addr)
+{
+	return nfs_find_client(addr, 4);
+}
+
+static inline void put_session_client(struct nfs4_session *session)
+{
+}
+
 #endif /* CONFIG_NFS_V4_1 */
 
 extern __be32 nfs4_callback_getattr(struct cb_getattrargs *args,
diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c
index 2e62155..d02997a 100644
--- a/fs/nfs/callback_proc.c
+++ b/fs/nfs/callback_proc.c
@@ -21,12 +21,6 @@
 #define NFSDBG_FACILITY NFSDBG_CALLBACK
 #endif
 
-static struct nfs_client *
-find_client_from_cps(struct cb_process_state *cps, struct sockaddr *addr)
-{
-	return cps->session ? cps->session->clp : nfs_find_client(addr, 4);
-}
-
 __be32 nfs4_callback_getattr(struct cb_getattrargs *args,
 			     struct cb_getattrres *res,
 			     struct cb_process_state *cps)
diff --git a/fs/nfs/callback_xdr.c b/fs/nfs/callback_xdr.c
index 1650ab0..01688ce 100644
--- a/fs/nfs/callback_xdr.c
+++ b/fs/nfs/callback_xdr.c
@@ -770,8 +770,7 @@ static __be32 nfs4_callback_compound(struct svc_rqst *rqstp, void *argp, void *r
 
 	*hdr_res.status = status;
 	*hdr_res.nops = htonl(nops);
-	if (cps.session) /* matched by cb_sequence find_client_with_session */
-		nfs_put_client(cps.session->clp);
+	put_session_client(cps.session);
 	dprintk("%s: done, status = %u\n", __func__, ntohl(status));
 	return rpc_success;
 }
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index 755e555..6f14089 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -2,6 +2,8 @@
  * NFS internal definitions
  */
 
+#ifndef __LINUX_FS_NFS_INTERNAL_H
+#define __LINUX_FS_NFS_INTERNAL_H
 #include "nfs4_fs.h"
 #include <linux/mount.h>
 #include <linux/security.h>
@@ -415,3 +417,5 @@ static inline int nfs_restart_rpc(struct rpc_task *task, const struct nfs_client
 		return rpc_restart_call_prepare(task);
 	return rpc_restart_call(task);
 }
+
+#endif /* __LINUX_FS_NFS_INTERNAL_H */
-- 
1.7.2.1


  parent reply	other threads:[~2010-11-12  8:49 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12  8:48 [PATCH 00/22] rewrite of CB_LAYOUTRECALL and layoutstate code, try 2 Fred Isaman
2010-11-12  8:48 ` [PATCH 01/22] pnfs-submit: remove RPC_ASSASSINATED(task) checks Fred Isaman
2010-11-12  8:48 ` [PATCH 02/22] pnfs-submit: remove unnecessary field lgp->status Fred Isaman
2010-11-12  8:48 ` [PATCH 03/22] pnfs-submit: layoutreturn's rpc_call_op functions need to handle bulk returns Fred Isaman
2010-11-12  8:48 ` [PATCH 04/22] pnfs-submit: argument to should_free_lseg changed from lseg to range Fred Isaman
2010-11-12  8:48 ` [PATCH 05/22] pnfs-submit: change layout state seqlock to a spinlock Fred Isaman
2010-11-12  8:48 ` [PATCH 06/22] NFSv4.1: Callback share session between ops Fred Isaman
2010-11-12  8:48 ` [PATCH 07/22] SQUASHME: pnfs-submit: fixups for nfsv4.1 callbacks Fred Isaman
2010-11-12  8:48 ` Fred Isaman [this message]
2010-11-14 12:05   ` [PATCH 08/22] SQUASHME: allow cb_sequence changes to compile without v4.1 Benny Halevy
2010-11-15 15:07     ` Fred Isaman
2010-11-12  8:48 ` [PATCH 09/22] pnfs-submit: change pnfs_layout_segment refcounting from kref to atomic_t Fred Isaman
2010-11-12  8:48 ` [PATCH 10/22] pnfs-submit: Have LAYOUTGETS wait when lo->plh_block_lgets is set Fred Isaman
2010-11-12  8:48 ` [PATCH 11/22] pnfs-submit: remove _pnfs_can_return_lseg call from pnfs_clear_lseg_list Fred Isaman
2010-11-12  8:48 ` [PATCH 12/22] pnfs_submit: nfs4_layoutreturn_release should not reference results Fred Isaman
2010-11-12  8:48 ` [PATCH 13/22] pnfs-submit: reorganize struct cb_layoutrecallargs Fred Isaman
2010-11-12  8:48 ` [PATCH 14/22] pnfs-submit: rename lo->state to lo->plh_flags Fred Isaman
2010-11-12  8:48 ` [PATCH 15/22] pnfs-submit: change pnfs_layout_hdr refcount to atomic_t Fred Isaman
2010-11-12  8:48 ` [PATCH 16/22] pnfs-submit: rewrite of layout state handling and cb_layoutrecall Fred Isaman
2010-11-13  9:11   ` Trond Myklebust
2010-11-14 11:44     ` Benny Halevy
2010-11-14 11:50       ` Benny Halevy
2010-11-15 14:28         ` Fred Isaman
2010-11-14 15:43   ` Benny Halevy
2010-11-15 14:51     ` Fred Isaman
2010-11-15 16:17       ` Benny Halevy
2010-11-15 17:53         ` [nfsv4] " Fred Isaman
2010-11-15 19:19           ` Boaz Harrosh
2010-11-15 20:40             ` Fred Isaman
2010-11-16  9:54               ` Boaz Harrosh
2010-11-16 11:12                 ` Boaz Harrosh
2010-11-17 17:53           ` Benny Halevy
2010-11-12  8:48 ` [PATCH 17/22] pnfs-submit: increase number of outstanding CB_LAYOUTRECALLS we can handle Fred Isaman
2010-11-12  8:48 ` [PATCH 18/22] pnfs-submit: roc add layoutreturn op to close compound Fred Isaman
2010-11-12 16:31   ` Benny Halevy
2010-11-12 16:56     ` Fred Isaman
2010-11-14 10:54       ` Benny Halevy
2010-11-14 14:21       ` [PATCH] SQUASHME: pnfs-submit: encode layoutreturn on close before close Benny Halevy
2010-11-14 18:12         ` [PATCH 2/2] pnfs-submit: handle NFS4ERR_DELEG_REVOKED for LAYOUTRETURN Benny Halevy
2010-11-15 12:54           ` [PATCH 2/2 v2] " Benny Halevy
2010-11-15 15:02         ` [PATCH] SQUASHME: pnfs-submit: encode layoutreturn on close before close Fred Isaman
2010-11-15 15:34           ` Benny Halevy
2010-11-12  8:48 ` [PATCH 19/22] pnfs-submit refactor layoutcommit xdr structures Fred Isaman
2010-11-12  8:48 ` [PATCH 20/22] pnfs-submit refactor pnfs_layoutcommit_setup Fred Isaman
2010-11-12  8:48 ` [PATCH 21/22] pnfs_submit: roc add layoutcommit op to close compound Fred Isaman
2010-11-12  8:48 ` [PATCH 22/22] SQUASHME: make roc patches compile without v4.1 Fred Isaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289551724-18575-9-git-send-email-iisaman@netapp.com \
    --to=iisaman@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).