From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Wengang Wang <wen.gang.wang@oracle.com>,
linux-nfs@vger.kernel.org, greg.marsden@oracle.com,
joe.jin@oracle.com
Subject: Re: [PATCH] lockd: release memory for non-normal situation
Date: Mon, 22 Nov 2010 13:44:07 -0500 [thread overview]
Message-ID: <1290451447.2909.6.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <86295CE6-C2D8-4186-BF51-455A5C190F3A@oracle.com>
On Mon, 2010-11-22 at 12:15 -0500, Chuck Lever wrote:
> Hi-
>
> On Nov 22, 2010, at 7:40 AM, Wengang Wang wrote:
>
> > nlmclnt_proc() is neither releasing nlm_rqst nor dropping the ref on nlm_host.
> > Do the release work though I am not sure if it can really hit the situation.
>
> Based on casual code review, the only case where this is a possibility is the "out_unlock" label in nlmclnt_lock(). Otherwise, this patch introduces a double release in other cases, doesn't it?
No. It only occurs if !IS_GETLK(cmd) && !IS_SETLK(cmd) && !
IS_SETLKW(cmd). The VFS should ensure this never happens, so I don't
think this is an exploitable bug.
The question therefore is: do we add this fix, or do we just remove the
-EINVAL error condition and replace it by a BUG()?
Cheers
Trond
prev parent reply other threads:[~2010-11-22 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 12:40 [PATCH] lockd: release memory for non-normal situation Wengang Wang
2010-11-22 17:15 ` Chuck Lever
2010-11-22 18:44 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290451447.2909.6.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=chuck.lever@oracle.com \
--cc=greg.marsden@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=wen.gang.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).