From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.netapp.com ([216.240.18.37]:35409 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159Ab0K3NR2 convert rfc822-to-8bit (ORCPT ); Tue, 30 Nov 2010 08:17:28 -0500 Subject: Re: [PATCH 4/4] NFSv4: Send unmapped uid/gids to the server when using auth_sys From: Trond Myklebust To: Boaz Harrosh Cc: linux-nfs@vger.kernel.org In-Reply-To: <4CF4C798.2000009@panasas.com> References: <1291085863-3234-1-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-2-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-3-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-4-git-send-email-Trond.Myklebust@netapp.com> <1291085863-3234-5-git-send-email-Trond.Myklebust@netapp.com> <4CF4C798.2000009@panasas.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 30 Nov 2010 08:17:17 -0500 Message-ID: <1291123037.3204.5.camel@heimdal.trondhjem.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Tue, 2010-11-30 at 11:44 +0200, Boaz Harrosh wrote: > On 11/30/2010 04:57 AM, Trond Myklebust wrote: > > Signed-off-by: Trond Myklebust > > --- > > fs/nfs/client.c | 16 ++++++++++++++++ > > fs/nfs/idmap.c | 21 +++++++++++++-------- > > fs/nfs/nfs4proc.c | 8 +++++++- > > include/linux/nfs_fs_sb.h | 1 + > > 4 files changed, 37 insertions(+), 9 deletions(-) > > > > diff --git a/fs/nfs/client.c b/fs/nfs/client.c > > index 0870d0d..fb84771 100644 > > --- a/fs/nfs/client.c > > +++ b/fs/nfs/client.c > > @@ -58,6 +58,11 @@ static LIST_HEAD(nfs_volume_list); > > static DECLARE_WAIT_QUEUE_HEAD(nfs_client_active_wq); > > > > /* > > + * Turn off NFSv4 uid/gid mapping when using AUTH_SYS > > + */ > > +static int nfs4_disable_idmapping = 0; > > The double negative is a bit hard. I had to read it 3 times to > register. Perhaps consider reversing the name and the default > > +static int nfs4_enable_idmapping = 1; No. That suggests that idmapping is optional and that you are fine not enabling it. What we're doing here is adding in a hack that is not tolerated by most servers. People _should_ have to think before disabling idmapping. Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com