From: Fred Isaman <iisaman@netapp.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 2/3] pnfs-submit: wave2: Remove smp barrier in get_layout_hdr
Date: Tue, 14 Dec 2010 17:02:59 -0500 [thread overview]
Message-ID: <1292364180-28512-3-git-send-email-iisaman@netapp.com> (raw)
In-Reply-To: <1292364180-28512-1-git-send-email-iisaman@netapp.com>
Trond points out that, since this is always called inside some
spinlock, the barrier is not necessay.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
---
fs/nfs/pnfs.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index c22e439..b815e3e 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -237,7 +237,6 @@ void
get_layout_hdr(struct pnfs_layout_hdr *lo)
{
atomic_inc(&lo->plh_refcount);
- smp_mb__after_atomic_inc();
}
static void
--
1.7.2.1
next prev parent reply other threads:[~2010-12-14 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 22:02 [PATCH 0/3] pnfs: additional wave2 patches Fred Isaman
2010-12-14 22:02 ` [PATCH 1/3] pnfs-submit: wave2: remove forgotten layoutreturn struct definitions Fred Isaman
2010-12-14 22:02 ` Fred Isaman [this message]
2010-12-14 22:03 ` [PATCH 3/3] pnfs-submit: wave2: make put_layout_hdr have args consistent with related functions Fred Isaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292364180-28512-3-git-send-email-iisaman@netapp.com \
--to=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).