* [PATCH 1/1] NFS: fix handling of malloc failure during nfs_flush_multi()
@ 2011-01-19 19:18 Fred Isaman
2011-01-19 19:42 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Fred Isaman @ 2011-01-19 19:18 UTC (permalink / raw)
To: linux-nfs; +Cc: Trond Myklebust
Cleanup of the allocated list entries should not call
put_nfs_open_context() on each entry, as the context will
always be NULL, causing an oops.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
---
fs/nfs/write.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 10d648e..c8278f4 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -932,7 +932,7 @@ out_bad:
while (!list_empty(&list)) {
data = list_entry(list.next, struct nfs_write_data, pages);
list_del(&data->pages);
- nfs_writedata_release(data);
+ nfs_writedata_free(data);
}
nfs_redirty_request(req);
return -ENOMEM;
--
1.7.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] NFS: fix handling of malloc failure during nfs_flush_multi()
2011-01-19 19:18 [PATCH 1/1] NFS: fix handling of malloc failure during nfs_flush_multi() Fred Isaman
@ 2011-01-19 19:42 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2011-01-19 19:42 UTC (permalink / raw)
To: Fred Isaman; +Cc: linux-nfs
On Wed, 2011-01-19 at 14:18 -0500, Fred Isaman wrote:
> Cleanup of the allocated list entries should not call
> put_nfs_open_context() on each entry, as the context will
> always be NULL, causing an oops.
>
> Signed-off-by: Fred Isaman <iisaman@netapp.com>
> ---
> fs/nfs/write.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/write.c b/fs/nfs/write.c
> index 10d648e..c8278f4 100644
> --- a/fs/nfs/write.c
> +++ b/fs/nfs/write.c
> @@ -932,7 +932,7 @@ out_bad:
> while (!list_empty(&list)) {
> data = list_entry(list.next, struct nfs_write_data, pages);
> list_del(&data->pages);
> - nfs_writedata_release(data);
> + nfs_writedata_free(data);
> }
> nfs_redirty_request(req);
> return -ENOMEM;
Yep. That looks like a long standing bug. Will apply...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-19 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-19 19:18 [PATCH 1/1] NFS: fix handling of malloc failure during nfs_flush_multi() Fred Isaman
2011-01-19 19:42 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).