* [PATCH] Fixed segfault in rpc.mountd
@ 2011-01-26 12:57 Steve Dickson
2011-01-26 15:35 ` Chuck Lever
2011-01-26 16:34 ` Steve Dickson
0 siblings, 2 replies; 4+ messages in thread
From: Steve Dickson @ 2011-01-26 12:57 UTC (permalink / raw)
To: Linux NFS Mailing list
A unallocated piece of memory, instead of a NULL point, was being
used to initialize a ->next point in the mount link list which
caused a segfault after a few remote accesses via the showmount
command.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/mountd/rmtab.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
index d339296..527377f 100644
--- a/utils/mountd/rmtab.c
+++ b/utils/mountd/rmtab.c
@@ -205,6 +205,7 @@ mountlist_list(void)
}
if (stb.st_mtime != last_mtime) {
mountlist_freeall(mlist);
+ mlist = NULL;
last_mtime = stb.st_mtime;
setrmtabent("r");
--
1.7.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fixed segfault in rpc.mountd
2011-01-26 12:57 [PATCH] Fixed segfault in rpc.mountd Steve Dickson
@ 2011-01-26 15:35 ` Chuck Lever
2011-01-26 16:34 ` Steve Dickson
2011-01-26 16:34 ` Steve Dickson
1 sibling, 1 reply; 4+ messages in thread
From: Chuck Lever @ 2011-01-26 15:35 UTC (permalink / raw)
To: Steve Dickson; +Cc: Linux NFS Mailing list
On Jan 26, 2011, at 7:57 AM, Steve Dickson wrote:
> A unallocated piece of memory, instead of a NULL point, was being
> used to initialize a ->next point in the mount link list which
> caused a segfault after a few remote accesses via the showmount
> command.
I thought there was a patch on the list just like this last week... in any event:
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> utils/mountd/rmtab.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
> index d339296..527377f 100644
> --- a/utils/mountd/rmtab.c
> +++ b/utils/mountd/rmtab.c
> @@ -205,6 +205,7 @@ mountlist_list(void)
> }
> if (stb.st_mtime != last_mtime) {
> mountlist_freeall(mlist);
> + mlist = NULL;
> last_mtime = stb.st_mtime;
>
> setrmtabent("r");
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fixed segfault in rpc.mountd
2011-01-26 15:35 ` Chuck Lever
@ 2011-01-26 16:34 ` Steve Dickson
0 siblings, 0 replies; 4+ messages in thread
From: Steve Dickson @ 2011-01-26 16:34 UTC (permalink / raw)
To: Chuck Lever; +Cc: Linux NFS Mailing list
On 01/26/2011 10:35 AM, Chuck Lever wrote:
>
> On Jan 26, 2011, at 7:57 AM, Steve Dickson wrote:
>
>> A unallocated piece of memory, instead of a NULL point, was being
>> used to initialize a ->next point in the mount link list which
>> caused a segfault after a few remote accesses via the showmount
>> command.
>
> I thought there was a patch on the list just like this last week... in any event:
>
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Thanks!
steved.
>
>
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>> utils/mountd/rmtab.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
>> index d339296..527377f 100644
>> --- a/utils/mountd/rmtab.c
>> +++ b/utils/mountd/rmtab.c
>> @@ -205,6 +205,7 @@ mountlist_list(void)
>> }
>> if (stb.st_mtime != last_mtime) {
>> mountlist_freeall(mlist);
>> + mlist = NULL;
>> last_mtime = stb.st_mtime;
>>
>> setrmtabent("r");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fixed segfault in rpc.mountd
2011-01-26 12:57 [PATCH] Fixed segfault in rpc.mountd Steve Dickson
2011-01-26 15:35 ` Chuck Lever
@ 2011-01-26 16:34 ` Steve Dickson
1 sibling, 0 replies; 4+ messages in thread
From: Steve Dickson @ 2011-01-26 16:34 UTC (permalink / raw)
To: Steve Dickson; +Cc: Linux NFS Mailing list
On 01/26/2011 07:57 AM, Steve Dickson wrote:
> A unallocated piece of memory, instead of a NULL point, was being
> used to initialize a ->next point in the mount link list which
> caused a segfault after a few remote accesses via the showmount
> command.
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> utils/mountd/rmtab.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
> index d339296..527377f 100644
> --- a/utils/mountd/rmtab.c
> +++ b/utils/mountd/rmtab.c
> @@ -205,6 +205,7 @@ mountlist_list(void)
> }
> if (stb.st_mtime != last_mtime) {
> mountlist_freeall(mlist);
> + mlist = NULL;
> last_mtime = stb.st_mtime;
>
> setrmtabent("r");
Committed....
steved.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-26 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-26 12:57 [PATCH] Fixed segfault in rpc.mountd Steve Dickson
2011-01-26 15:35 ` Chuck Lever
2011-01-26 16:34 ` Steve Dickson
2011-01-26 16:34 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).