linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: andros@netapp.com
To: bhalevy@panasas.com
Cc: linux-nfs@vger.kernel.org, Fred Isaman <iisaman@netapp.com>
Subject: [PATCH pnfs-submit-wave3 update 3/5] wave3: document that we are relying on nfs_initiate_read not failing
Date: Tue,  1 Mar 2011 14:25:32 -0500	[thread overview]
Message-ID: <1299007534-4105-4-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1299007534-4105-3-git-send-email-andros@netapp.com>

From: Fred Isaman <iisaman@netapp.com>

With the curent code, rpc_run_task(), and thus nfs_initiate_read(),
can not fail if the task is pre-initialized.  Trond asked that
we document this in case of future code changes with a BUG_ON.

Signed-off-by: Fred Isaman <iisaman@netapp.com>
---
 fs/nfs/nfs4filelayout.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
index 45b650a..e76c582 100644
--- a/fs/nfs/nfs4filelayout.c
+++ b/fs/nfs/nfs4filelayout.c
@@ -203,6 +203,7 @@ filelayout_read_pagelist(struct nfs_read_data *data)
 	loff_t offset = data->args.offset;
 	u32 j, idx;
 	struct nfs_fh *fh;
+	int status;
 
 	dprintk("--> %s ino %lu pgbase %u req %Zu@%llu\n",
 		__func__, data->inode->i_ino,
@@ -231,8 +232,9 @@ filelayout_read_pagelist(struct nfs_read_data *data)
 	data->mds_offset = offset;
 
 	/* Perform an asynchronous read to ds */
-	nfs_initiate_read(data, ds->ds_clp->cl_rpcclient,
-			  &filelayout_read_call_ops);
+	status = nfs_initiate_read(data, ds->ds_clp->cl_rpcclient,
+				   &filelayout_read_call_ops);
+	BUG_ON(status != 0);
 	return PNFS_ATTEMPTED;
 }
 
-- 
1.6.2.5


  reply	other threads:[~2011-03-01 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 19:25 [PATCH pnfs-submit-wave3 update 0/5] Update tree to match submission andros
2011-03-01 19:25 ` [PATCH pnfs-submit-wave3 update 1/5] wave3: SQUASHME: remove comment to pnfs_pageio_init_read andros
2011-03-01 19:25   ` [PATCH pnfs-submit-wave3 update 2/5] wave3: clean up nfs4_reset_read to match write andros
2011-03-01 19:25     ` andros [this message]
2011-03-01 19:25       ` [PATCH pnfs-submit-wave3 update 4/5] wave3: clean up lseg after pg_doio function andros
2011-03-01 19:25         ` [PATCH pnfs-submit-wave3 update 5/5] SQUASHME: NFSv4.1: DS only check andros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299007534-4105-4-git-send-email-andros@netapp.com \
    --to=andros@netapp.com \
    --cc=bhalevy@panasas.com \
    --cc=iisaman@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).