* Re: [Bug #30322] BUG in xs_tcp_setup_socket
[not found] ` <sUKqYsqyJ4N.A.n0F.3-3cNB@chimera>
@ 2011-03-10 0:48 ` Andrew Morton
2011-03-10 14:08 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2011-03-10 0:48 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Kernel Testers List, Maciej Rutecki,
Florian Mickler, Ben Hutchings, Pavel Emelyanov, linux-nfs,
Trond Myklebust, J. Bruce Fields, David Miller
On Sun, 6 Mar 2011 13:40:43 +0100 (CET)
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> This message has been generated automatically as a part of a report
> of regressions introduced between 2.6.36 and 2.6.37.
>
> The following bug entry is on the current list of known regressions
> introduced between 2.6.36 and 2.6.37. Please verify if it still should
> be listed and let the tracking team know (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=30322
> Subject : BUG in xs_tcp_setup_socket
> Submitter : Ben Hutchings <bhutchings@solarflare.com>
> Date : 2011-03-01 20:34 (6 days old)
> Patch : http://article.gmane.org/gmane.linux.nfs/38949
>
Ben's patch is a no-brainer but it is not yet in mainline or linux-next.
I'm not on linux-nfs so I recreated it as below.
Subject: sunrpc: propagate errors from xs_bind() through xs_create_sock()
From: Ben Hutchings <bhutchings@solarflare.com>
xs_create_sock() is supposed to return a pointer or an ERR_PTR-encoded
error, but it currently returns 0 if xs_bind() fails. This causes the
kernel to go BUG, as described in
https://bugzilla.kernel.org/show_bug.cgi?id=30322.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Maciej Rutecki <maciej.rutecki@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
net/sunrpc/xprtsock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN net/sunrpc/xprtsock.c~sunrpc-propagate-errors-from-xs_bind-through-xs_create_sock net/sunrpc/xprtsock.c
--- a/net/sunrpc/xprtsock.c~sunrpc-propagate-errors-from-xs_bind-through-xs_create_sock
+++ a/net/sunrpc/xprtsock.c
@@ -1631,7 +1631,8 @@ static struct socket *xs_create_sock(str
}
xs_reclassify_socket(family, sock);
- if (xs_bind(transport, sock)) {
+ err = xs_bind(transport, sock);
+ if (err) {
sock_release(sock);
goto out;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread