Linux NFS development
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: peter.staubach@emc.com
Cc: bjschuma@netapp.com, linux-nfs@vger.kernel.org
Subject: RE: [PATCH 3/3] NFS: Detect loops in a readdir due to bad cookies
Date: Wed, 23 Mar 2011 14:17:47 -0400	[thread overview]
Message-ID: <1300904267.11677.47.camel@lade.trondhjem.org> (raw)
In-Reply-To: <5E6794FC7B8FCA41A704019BE3C70E8B0693F02D@MX31A.corp.emc.com>

On Wed, 2011-03-23 at 14:10 -0400, peter.staubach@emc.com wrote:
> Doesn't returning identical cookies for multiple, different entries in the same directory constitute a protocol violation?

Yes. Unfortunately quite a few common filesystems seem quite happy to do
so.

Most of the time they get away with it, but occasionally we do get
support requests from people asking 'why is my NFS client looping
forever?'.
With Bryan's patches, we now have a way to have the client error out
instead of looping, and notify the admin that their server is exporting
a broken underlying filesystem.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


  reply	other threads:[~2011-03-23 18:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 17:39 [PATCH 3/3] NFS: Detect loops in a readdir due to bad cookies Bryan Schumaker
2011-03-23 18:10 ` peter.staubach
2011-03-23 18:17   ` Trond Myklebust [this message]
2011-03-23 18:11 ` Trond Myklebust
2011-03-23 18:25 ` J. Bruce Fields
2011-03-23 18:34   ` Trond Myklebust
2011-03-23 18:42     ` peter.staubach
2011-03-23 18:48       ` Trond Myklebust
2011-03-23 21:27         ` NeilBrown
2011-03-23 21:36           ` Daniel.Muntz
2011-03-23 21:55             ` NeilBrown
2011-03-23 18:43     ` peter.staubach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300904267.11677.47.camel@lade.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=bjschuma@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=peter.staubach@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox