From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: "Dr. J. Bruce Fields" <bfields@fieldses.org>
Cc: Harry Edmon <harry@uw.edu>, Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org
Subject: Re: 2.6.38.6 - state manager constantly respawns
Date: Fri, 20 May 2011 15:15:33 -0400 [thread overview]
Message-ID: <1305918933.14253.5.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20110520185935.GC11670@fieldses.org>
On Fri, 2011-05-20 at 14:59 -0400, Dr. J. Bruce Fields wrote:
> > Bruce,
> >
> > If the clientid expired, is it possible that the server may have handed
> > out the same numerical short clientid to someone else and that explains
> > why the RENEW is succeeding?
>
> Clientid's are created from a u32 counter that's sampled only under the
> state lock, so it sounds unlikely.
>
> I think more likely would be some bug affecting the lifetime of a
> stateid--e.g. if the server destroyed a lock stateid earlier than it
> should in some case, then this would happen. (Since, as I say, we
> assume EXPIRED for any stateid we don't recognize.)
Shouldn't that be a NFS4ERR_BAD_STATEID instead of NFS4ERR_EXPIRED? The
latter should really be reserved for the case where you know that this
stateid came from an expired lease.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
next prev parent reply other threads:[~2011-05-20 19:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 18:40 2.6.38.6 - state manager constantly respawns Harry Edmon
2011-05-16 18:45 ` Chuck Lever
2011-05-16 19:12 ` Harry Edmon
2011-05-16 19:22 ` Chuck Lever
2011-05-16 19:36 ` Harry Edmon
2011-05-16 19:43 ` Trond Myklebust
2011-05-16 19:48 ` Harry Edmon
2011-05-16 19:54 ` Trond Myklebust
2011-05-16 20:20 ` Dr. J. Bruce Fields
2011-05-16 20:53 ` Dr. J. Bruce Fields
2011-05-20 16:20 ` Harry Edmon
2011-05-20 17:26 ` Dr. J. Bruce Fields
2011-05-20 17:52 ` Trond Myklebust
2011-05-20 18:36 ` Trond Myklebust
2011-05-20 18:59 ` Dr. J. Bruce Fields
2011-05-20 19:15 ` Trond Myklebust [this message]
2011-05-20 19:32 ` Dr. J. Bruce Fields
2011-05-20 18:47 ` Dr. J. Bruce Fields
2011-05-20 18:50 ` Bryan Schumaker
2011-05-20 19:29 ` Harry Edmon
2011-05-20 19:39 ` Andy Adamson
2011-05-20 19:40 ` Trond Myklebust
2011-05-20 19:44 ` Harry Edmon
2011-05-20 20:11 ` Trond Myklebust
2011-05-20 20:23 ` Harry Edmon
2011-05-20 20:27 ` Trond Myklebust
2011-05-20 18:35 ` Harry Edmon
2011-05-16 20:21 ` Chuck Lever
2011-05-16 20:33 ` Trond Myklebust
[not found] ` <1305578007.19725.24.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2011-05-16 20:37 ` Harry Edmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305918933.14253.5.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=harry@uw.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).