linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
	Fred Isaman <iisaman@netapp.com>,
	NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [RFC] pnfs: Send layoutreturn, if Return-On-Close is set
Date: Thu, 26 May 2011 10:16:37 -0400	[thread overview]
Message-ID: <1306419397.2984.14.camel@lade.trondhjem.org> (raw)
In-Reply-To: <4DDE536E.8020805@panasas.com>

On Thu, 2011-05-26 at 16:19 +0300, Boaz Harrosh wrote: 
> Every thing was ready, in pnfs_roc(). The segments released
> and the LO state blocked til after the close is done. All that
> is needed is to send the actual layoutreturn synchronously.

Why would we want to do this?

Return-on-close was initially considered useful only for debugging.

At the interim IETF meeting in Sunnyvale, we also discussed the case
where the forgetful client has forgotten the layout: in this case the
server may decide to forget the layout too. There is no controversy in
doing this, since both the client and the server know that any
outstanding layout is supposed to be returned (and if there is a
problem, then the server always has the option of sending a
CB_LAYOUTRECALL).

Adding a synchronous call to close is in any case a bug since close can
on occasion be sent in situations where we don't allow sleeping.

Cheers
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


  reply	other threads:[~2011-05-26 14:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26 13:19 [RFC] pnfs: Send layoutreturn, if Return-On-Close is set Boaz Harrosh
2011-05-26 14:16 ` Trond Myklebust [this message]
2011-05-26 14:45   ` Boaz Harrosh
2011-05-26 15:04     ` Trond Myklebust
2011-05-26 15:19       ` More NFSv4.1 issues [WAS: Re: [RFC] pnfs: Send layoutreturn, if Return-On-Close is set] Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306419397.2984.14.camel@lade.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=bhalevy@panasas.com \
    --cc=bharrosh@panasas.com \
    --cc=iisaman@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).