From: Richard Weinberger <richard@nod.at>
To: Steve Dickson <steved@redhat.com>
Cc: linux-nfs <linux-nfs@vger.kernel.org>,
david <david@sigma-star.at>, bfields <bfields@fieldses.org>,
luis turcitu <luis.turcitu@appsbroker.com>,
david young <david.young@appsbroker.com>,
david oberhollenzer <david.oberhollenzer@sigma-star.at>,
trond myklebust <trond.myklebust@hammerspace.com>,
anna schumaker <anna.schumaker@netapp.com>,
chris chilvers <chris.chilvers@appsbroker.com>
Subject: Re: [PATCH 2/5] exports: Implement new export option reexport=
Date: Tue, 10 May 2022 18:06:12 +0200 (CEST) [thread overview]
Message-ID: <1306432546.48658.1652198772007.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <200443c8-c53a-a7ff-0876-aff144963267@redhat.com>
----- Ursprüngliche Mail -----
> Von: "Steve Dickson" <steved@redhat.com>
> A compile error...
> reexport.c: In function ‘reexpdb_apply_reexport_settings’:
> reexport.c:335:25: error: label ‘out’ used but not defined
> 335 | goto out;
> | ^~~~
>
>
>> + }
>> + }
>> +
>> + if (ep->e_fsid) {
>> + if (ep->e_fsid != fsidnum) {
>> + xlog(L_ERROR, "%s:%i: Selected 'reexport=' mode requires configured
>> numerical 'fsid=' to agree with reexport db entry",
>> + flname, flline);
>> + ret = -1;
>> + }
>> + } else {
>> + ep->e_fsid = fsidnum;
>> + }
> I'm assuming this is where the out needs to be
>
> out:
Patch 3/5 adds the label.
Looks like I messed up something while reordering patches. ;-\
Do you want me to resend the patch series immediately or shall I want for further comments?
Thanks,
//richard
next prev parent reply other threads:[~2022-05-10 16:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 8:50 [PATCH 0/5] nfs-utils: Improving NFS re-exports Richard Weinberger
2022-05-02 8:50 ` [PATCH 1/5] Implement reexport helper library Richard Weinberger
2022-05-10 13:32 ` Steve Dickson
2022-05-10 13:48 ` Chuck Lever III
2022-05-10 13:59 ` Richard Weinberger
2022-05-10 14:04 ` Steve Dickson
2022-05-10 14:17 ` Chuck Lever III
2022-05-10 20:08 ` Steve Dickson
2022-05-10 20:32 ` Richard Weinberger
2022-05-10 20:37 ` Chuck Lever III
2022-05-02 8:50 ` [PATCH 2/5] exports: Implement new export option reexport= Richard Weinberger
2022-05-10 14:32 ` Steve Dickson
2022-05-10 16:06 ` Richard Weinberger [this message]
2022-05-10 19:26 ` Steve Dickson
2022-05-02 8:50 ` [PATCH 3/5] export: Implement logic behind reexport= Richard Weinberger
2022-05-02 8:50 ` [PATCH 4/5] export: Avoid fsid= conflicts Richard Weinberger
2022-05-02 8:50 ` [PATCH 5/5] reexport: Make state database location configurable Richard Weinberger
2022-05-02 16:17 ` [PATCH 0/5] nfs-utils: Improving NFS re-exports J. Bruce Fields
2022-05-02 22:46 ` Steve Dickson
2022-05-03 0:00 ` Chuck Lever III
2022-05-23 7:53 ` Richard Weinberger
2022-05-23 14:25 ` Chuck Lever III
2022-05-23 14:29 ` bfields
2022-05-23 14:31 ` bfields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306432546.48658.1652198772007.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=chris.chilvers@appsbroker.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=david.young@appsbroker.com \
--cc=david@sigma-star.at \
--cc=linux-nfs@vger.kernel.org \
--cc=luis.turcitu@appsbroker.com \
--cc=steved@redhat.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).