From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF115C433F5 for ; Thu, 10 Feb 2022 13:28:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242201AbiBJN2q (ORCPT ); Thu, 10 Feb 2022 08:28:46 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240857AbiBJN2q (ORCPT ); Thu, 10 Feb 2022 08:28:46 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 587E5BD9 for ; Thu, 10 Feb 2022 05:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644499720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3Mkgnkv+LYdj2GliLfv2m1HUFq1g4axJGgaCWu1jAcU=; b=eOxAg8ERrlRwuFVz47/TMi8/TMp7pS7J7fMPuLFpqoVoriLRGV+cZ+iffi6CvFRqyEoufr 0iYaZDCQFc74srAq+UV4bjx+UDc7PUq9UMGQmEhfs9VqUQNKEHoGEIhBKA2l1rP4LvAWhT cCwFs8RiCpGf9xfzl0Ovc69CyeVpxSg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-220-XEyCTCu4MDSuhcMP-IzrCA-1; Thu, 10 Feb 2022 08:28:39 -0500 X-MC-Unique: XEyCTCu4MDSuhcMP-IzrCA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 69BFA46860; Thu, 10 Feb 2022 13:28:38 +0000 (UTC) Received: from [172.16.176.1] (ovpn-66-2.rdu2.redhat.com [10.10.66.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F16A51062220; Thu, 10 Feb 2022 13:28:35 +0000 (UTC) From: "Benjamin Coddington" To: "Steve Dickson" Cc: "Chuck Lever III" , "Linux NFS Mailing List" Subject: Re: [nfs-utils PATCH] nfs4id: a tool to create and persist nfs4 client uniquifiers Date: Thu, 10 Feb 2022 08:28:34 -0500 Message-ID: <13069AB1-28EB-43F6-83BF-41E9B9501C75@redhat.com> In-Reply-To: <281b1976-9b40-fc53-301a-2846c2ead5aa@redhat.com> References: <6f01c382-8da5-5673-30db-0c0099d820b5@redhat.com> <33B10EBB-3DD1-45FE-B7D2-D5EA21DFB172@oracle.com> <839b09ed-fd21-bda1-0502-d7c6f1fa9e88@redhat.com> <32D8EBC9-652A-49D7-B763-A82E2AEF6282@oracle.com> <281b1976-9b40-fc53-301a-2846c2ead5aa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 8 Feb 2022, at 17:39, Steve Dickson wrote: > On 2/8/22 4:18 PM, Chuck Lever III wrote: >> >> >>> On Feb 8, 2022, at 2:29 PM, Steve Dickson wrote: >>> >>> >>> >>> On 2/8/22 11:21 AM, Chuck Lever III wrote: >>>>> On Feb 8, 2022, at 11:04 AM, Steve Dickson >>>>> wrote: >>>>> >>>>> Hello, >>>>> >>>>> On 2/4/22 7:56 AM, Benjamin Coddington wrote: >>>>>> The nfs4id program will either create a new UUID from a random >>>>>> source or >>>>>> derive it from /etc/machine-id, else it returns a UUID that has >>>>>> already >>>>>> been written to /etc/nfs4-id. This small, lightweight tool is >>>>>> suitable for >>>>>> execution by systemd-udev in rules to populate the nfs4 client >>>>>> uniquifier. >>>>>> Signed-off-by: Benjamin Coddington >>>>>> --- >>>>>> .gitignore | 1 + >>>>>> configure.ac | 4 + >>>>>> tools/Makefile.am | 1 + >>>>>> tools/nfs4id/Makefile.am | 8 ++ >>>>>> tools/nfs4id/nfs4id.c | 184 >>>>>> +++++++++++++++++++++++++++++++++++++++ >>>>>> tools/nfs4id/nfs4id.man | 29 ++++++ >>>>>> 6 files changed, 227 insertions(+) >>>>>> create mode 100644 tools/nfs4id/Makefile.am >>>>>> create mode 100644 tools/nfs4id/nfs4id.c >>>>>> create mode 100644 tools/nfs4id/nfs4id.man >>>>> Just a nit... naming convention... In the past >>>>> we never put the protocol version in the name. >>>>> Do a ls tools and utils directory and you >>>>> see what I mean.... >>>>> >>>>> Would it be a problem to change the name from >>>>> nfs4id to nfsid? >>>> nfs4id is pretty generic, too. >>>> Can we go with nfs-client-id ? >>> I'm never been big with putting '-' >>> in command names... nfscltid would >>> be better IMHO... if we actually >>> need the 'clt' in the name. >> >> We have nfsidmap already. IMO we need some distinction >> with user ID mapping tools... and some day we might >> want to manage server IDs too (see EXCHANGE_ID). > Hmm... So we could not use the same tool to do > both the server and client, via flags? > >> >> nfsclientid then? > You like to type more than I do... You always have... :-) > > But like I started the conversation... the naming is > a nit... but I would like to see one tool to set the > ids for both the server and client... how about > nfsid -s and nfsid -c The tricky thing here is that this little binary isn't going to set anything, and we probably never want people to run it from the command line. A 'nfsid -s' and 'nfsid -c' seem to want to do much more. I feel they are out of scope for the problem I'm trying to solve: I need something that will generate a unique value, and persist it, suitable for execution in a udevd rule. Perhaps we can stop worrying so much about the name of this as I don't think it should be a first-class nfs-utils command, rather just a helper for udev. And maybe the name can reflect that - "nfsuuid" ? Ben