From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH] mountd: group length not being set correctly in auth_unix_gid
Date: Tue, 7 Jun 2011 11:56:28 -0400 [thread overview]
Message-ID: <1307462188-13122-1-git-send-email-steved@redhat.com> (raw)
From: Rinat Bikov <becase@altlinux.org>
Commit 9274e94d introduce dynamic buffering for gids lists.
In that patch there was a bug that only used the dynamic
length on the first call, resulting in the dynamic length
not being dynamic at all.
Reported-by: Rinat Bikov <becase@altlinux.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/mountd/cache.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index 0c4a03d..6084893 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -147,8 +147,9 @@ static void auth_unix_gid(FILE *f)
if (!groups)
return;
- groups_len = ngroups = INITIAL_MANAGED_GROUPS;
+ groups_len = INITIAL_MANAGED_GROUPS;
}
+ ngroups = groups_len;
if (readline(fileno(f), &lbuf, &lbuflen) != 1)
return;
--
1.7.5.1
next reply other threads:[~2011-06-07 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 15:56 Steve Dickson [this message]
2011-06-07 18:41 ` [PATCH] mountd: group length not being set correctly in auth_unix_gid Pavel Shilovsky
2011-06-08 3:16 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307462188-13122-1-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).