From: Boaz Harrosh <bharrosh@panasas.com>
To: Benny Halevy <bhalevy@panasas.com>,
open-osd <osd-dev@open-osd.org>,
NFS list <linux-nfs@vger.kernel.org>
Subject: [PATCH 8/8] pnfsd-exofs: layoutreturn pnfs-obj information decoding
Date: Tue, 14 Jun 2011 17:03:39 -0400 [thread overview]
Message-ID: <1308085419-12686-1-git-send-email-bharrosh@panasas.com> (raw)
In-Reply-To: <4DF7CA2F.7030407@panasas.com>
Use pnfs_osd_xdr_decode_ioerr() in exofs_layout_return,
and print the received errors.
TODO: Call exofs_file_recovery() on errors that need it.
(When it's implemented)
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/exofs/export.c | 22 +++++++++++++++++++++-
1 files changed, 21 insertions(+), 1 deletions(-)
diff --git a/fs/exofs/export.c b/fs/exofs/export.c
index c0705df..8281c85 100644
--- a/fs/exofs/export.c
+++ b/fs/exofs/export.c
@@ -229,11 +229,31 @@ static int exofs_layout_commit(
return 0;
}
+static void exofs_handle_error(struct pnfs_osd_ioerr *ioerr)
+{
+ EXOFS_ERR("exofs_handle_error: errno=%d is_write=%d obj=0x%llx "
+ "offset=0x%llx length=0x%llx\n",
+ ioerr->oer_errno, ioerr->oer_iswrite,
+ _LLU(ioerr->oer_component.oid_object_id),
+ _LLU(ioerr->oer_comp_offset),
+ _LLU(ioerr->oer_comp_length));
+}
+
static int exofs_layout_return(
struct inode *inode,
const struct nfsd4_pnfs_layoutreturn_arg *args)
{
- /* TODO: Decode the pnfs_osd_ioerr if lrf_body_len > 0 */
+ struct exp_xdr_stream xdr = {
+ .p = args->lrf_body,
+ .end = args->lrf_body + exp_xdr_qwords(args->lrf_body_len),
+ };
+ struct pnfs_osd_ioerr ioerr;
+
+ EXOFS_DBGMSG("(0x%lx) cookie %p body_len %d\n",
+ inode->i_ino, args->lr_cookie, args->lrf_body_len);
+
+ while (pnfs_osd_xdr_decode_ioerr(&ioerr, &xdr))
+ exofs_handle_error(&ioerr);
if (args->lr_cookie) {
struct exofs_i_info *oi = exofs_i(inode);
--
1.7.3.4
next prev parent reply other threads:[~2011-06-14 21:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 20:53 [PATCHSET 0/8] pnfsd-exofs: New set of exofs pnfs export patches Boaz Harrosh
2011-06-14 21:00 ` Benny Halevy
2011-06-14 22:24 ` Benny Halevy
2011-06-14 21:02 ` [PATCH 1/8] nfs_xdr: Move nfs4_string definition out of #ifdef CONFIG_NFS_V4 Boaz Harrosh
2011-06-14 21:02 ` [PATCH 2/8] exofs: pnfs-tree: Remove pnfs-osd private definitions Boaz Harrosh
2011-06-14 21:03 ` [PATCH 4/8] pnfsd-exofs: pnfs objects server XDR functions Boaz Harrosh
2011-06-14 21:03 ` [PATCH 5/8] pnfsd-exofs: Add pNFS export support Boaz Harrosh
2011-06-14 21:03 ` [PATCH 6/8] pnfsd-exofs: get_device_info implementation Boaz Harrosh
2011-06-14 21:03 ` Boaz Harrosh [this message]
2011-06-14 21:20 ` [PATCH 3/8] pnfs-obj: pnfs_osd_xdr: Remove dead code and cleanup Boaz Harrosh
2011-06-14 21:20 ` [PATCH 7/8] pnfsd-exofs: Recall layouts on truncate Boaz Harrosh
2011-06-14 21:32 ` [PATCHSET 0/10] pnfsd-exofs: SQUASHMES that went into last changes Boaz Harrosh
2011-06-14 21:35 ` [PATCH 01/10] SQUASHME: pnfsd-exofs xdr_srv: Wrong type in comments Boaz Harrosh
2011-06-14 21:35 ` [PATCH 02/10] SQUASHME: pnfsd-exofs: Move all Server xdr definisions to separate header Boaz Harrosh
2011-06-14 21:36 ` [PATCH 03/10] SQUASHME: pnfsd-exofs: Prettify pnfs_osd_xdr_srv.h Boaz Harrosh
2011-06-14 21:36 ` [PATCH 04/10] SQUASHME: pnfsd-exofs: Change layout encoding to two pass Boaz Harrosh
2011-06-14 21:36 ` [PATCH 05/10] SQUASHME: pnfsd-exofs: osd_xdr_srv: Convert XDR API to return enum nfsstat4 Boaz Harrosh
2011-06-14 21:36 ` [PATCH 06/10] SQUASHME: pnfsd-exofs: Server xdr definisions were moved to a separate header Boaz Harrosh
2011-06-14 21:36 ` [PATCH 07/10] SQUASHME: pnfsd-exofs: osd_xdr_srv header moved Boaz Harrosh
2011-06-14 21:36 ` [PATCH 08/10] SQUASHME: pnfsd-exofs: layout encoding was Changed to two pass Boaz Harrosh
2011-06-14 21:36 ` [PATCH 09/10] SQUASHME: pnfsd-exofs: Convert XDR API to return enum nfsstat4 Boaz Harrosh
2011-06-14 21:38 ` [PATCH 10/10] SQUASHME: pnfsd-exofs: checkpatch love and a dprint Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308085419-12686-1-git-send-email-bharrosh@panasas.com \
--to=bharrosh@panasas.com \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).