From: greearb@candelatech.com
To: linux-nfs@vger.kernel.org
Cc: Ben Greear <greearb@candelatech.com>
Subject: [PATCH 01/11] sunrpc: Don't attempt to bind to AF_UNSPEC address.
Date: Wed, 22 Jun 2011 14:36:41 -0700 [thread overview]
Message-ID: <1308778611-9370-2-git-send-email-greearb@candelatech.com> (raw)
In-Reply-To: <1308778611-9370-1-git-send-email-greearb@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
This lets calling code simply pass AF_UNSPEC addresses
instead of adding lots of checks to conditionally pass
NULL addresses.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 72abb73... 37299c0... M net/sunrpc/xprtsock.c
net/sunrpc/xprtsock.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 72abb73..37299c0 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2509,9 +2509,9 @@ static struct rpc_xprt *xs_setup_xprt(struct xprt_create *args,
new = container_of(xprt, struct sock_xprt, xprt);
memcpy(&xprt->addr, args->dstaddr, args->addrlen);
xprt->addrlen = args->addrlen;
- if (args->srcaddr)
+ if (args->srcaddr && (args->srcaddr->sa_family != AF_UNSPEC)) {
memcpy(&new->srcaddr, args->srcaddr, args->addrlen);
- else {
+ } else {
int err;
err = xs_init_anyaddr(args->dstaddr->sa_family,
(struct sockaddr *)&new->srcaddr);
--
1.7.3.4
next prev parent reply other threads:[~2011-06-22 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 21:36 [PATCH 00/11] NFS: Support binding to source address greearb
2011-06-22 21:36 ` greearb [this message]
2011-06-22 21:36 ` [PATCH 02/11] nfs: Two AF_UNSPEC addresses should always match each other greearb
2011-06-22 21:36 ` [PATCH 03/11] nfs: Add srcaddr member to nfs_client greearb
2011-06-22 21:36 ` [PATCH 04/11] nfs: Use request destination addr as callback source addr greearb
2011-06-22 21:36 ` [PATCH 05/11] nfs: Pay attention to srcaddr in v4.1 callback logic greearb
2011-06-22 21:36 ` [PATCH 06/11] nfs: Use srcaddr in nfs_match_client greearb
2011-06-22 21:36 ` [PATCH 07/11] nfs: Add srcaddr to /proc/fs/nfsfs/servers greearb
2011-06-22 21:36 ` [PATCH 08/11] nfs: Pass srcaddr into mount request greearb
2011-06-22 21:36 ` [PATCH 09/11] nfs: Propagate src-addr in client code greearb
2011-06-22 21:36 ` [PATCH 10/11] nfs: Bind to srcaddr in rpcb_create greearb
2011-06-22 21:36 ` [PATCH 11/11] nfs: Support srcaddr= to bind to specific IP address greearb
2011-06-23 14:59 ` [PATCH 00/11] NFS: Support binding to source address Chuck Lever
2011-06-23 15:29 ` Ben Greear
2011-06-23 15:46 ` Chuck Lever
2011-06-23 16:05 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308778611-9370-2-git-send-email-greearb@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).