From: Malahal Naineni <malahal@us.ibm.com>
To: linux-nfs@vger.kernel.org
Cc: Malahal Naineni <malahal@us.ibm.com>
Subject: [PATCH 1/2] nfs4-acl-tools: Fix segfault if format of the input file is incorrect
Date: Thu, 21 Jul 2011 13:35:06 -0700 [thread overview]
Message-ID: <1311280507-28957-1-git-send-email-malahal@us.ibm.com> (raw)
The sizeof operator, when applied to a parameter declared to have array,
yields the size of the adjusted (pointer) type, even if the parameter
declaration specifies a length.
Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
---
libnfs4acl/nfs4_ace_from_string.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libnfs4acl/nfs4_ace_from_string.c b/libnfs4acl/nfs4_ace_from_string.c
index 9d877fb..462fcc0 100644
--- a/libnfs4acl/nfs4_ace_from_string.c
+++ b/libnfs4acl/nfs4_ace_from_string.c
@@ -100,7 +100,7 @@ parse_alloc_fields(char *buf, char *fields[NUMFIELDS])
if (!buf)
return -EINVAL;
- memset(fields, 0, sizeof(fields));
+ memset(fields, 0, sizeof(char *) * NUMFIELDS);
for (i = 0; buf[i] != '\0'; i++) {
if (buf[i] == ':')
--
1.7.4.4
next reply other threads:[~2011-07-21 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 20:35 Malahal Naineni [this message]
2011-07-21 20:35 ` [PATCH 2/2] nfs4-acl-tools: Don't call free_fields when memory isn't allocated Malahal Naineni
2011-07-26 6:54 ` [PATCH 1/2] nfs4-acl-tools: Fix segfault if format of the input file is incorrect Venkateswararao Jujjuri
2011-07-26 17:58 ` Malahal Naineni
2011-08-05 20:05 ` J. Bruce Fields
2011-08-05 20:50 ` Malahal Naineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311280507-28957-1-git-send-email-malahal@us.ibm.com \
--to=malahal@us.ibm.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).