From: Jim Rees <rees@umich.edu>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: [PATCH v7 08/26] pnfs: cleanup_layoutcommit
Date: Sat, 30 Jul 2011 20:52:38 -0400 [thread overview]
Message-ID: <1312073576-11024-9-git-send-email-rees@umich.edu> (raw)
In-Reply-To: <1312073576-11024-1-git-send-email-rees@umich.edu>
From: Andy Adamson <andros@netapp.com>
This gives layout driver a chance to cleanup structures they put in at
encode_layoutcommit.
Signed-off-by: Andy Adamson <andros@netapp.com>
[fixup layout header pointer for layoutcommit]
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
[rm inode and pnfs_layout_hdr args from cleanup_layoutcommit()]
Signed-off-by: Jim Rees <rees@umich.edu>
---
fs/nfs/nfs4proc.c | 1 +
fs/nfs/nfs4xdr.c | 1 +
fs/nfs/pnfs.c | 8 ++++++++
fs/nfs/pnfs.h | 3 +++
include/linux/nfs_xdr.h | 1 +
5 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index e86de79..8c77039 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5963,6 +5963,7 @@ static void nfs4_layoutcommit_release(void *calldata)
struct nfs4_layoutcommit_data *data = calldata;
struct pnfs_layout_segment *lseg, *tmp;
+ pnfs_cleanup_layoutcommit(data);
/* Matched by references in pnfs_set_layoutcommit */
list_for_each_entry_safe(lseg, tmp, &data->lseg_list, pls_lc_list) {
list_del_init(&lseg->pls_lc_list);
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
index 0261669..1dce12f 100644
--- a/fs/nfs/nfs4xdr.c
+++ b/fs/nfs/nfs4xdr.c
@@ -5599,6 +5599,7 @@ static int decode_layoutcommit(struct xdr_stream *xdr,
int status;
status = decode_op_hdr(xdr, OP_LAYOUTCOMMIT);
+ res->status = status;
if (status)
return status;
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 3a47f7c..e550e88 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1411,6 +1411,14 @@ pnfs_set_layoutcommit(struct nfs_write_data *wdata)
}
EXPORT_SYMBOL_GPL(pnfs_set_layoutcommit);
+void pnfs_cleanup_layoutcommit(struct nfs4_layoutcommit_data *data)
+{
+ struct nfs_server *nfss = NFS_SERVER(data->args.inode);
+
+ if (nfss->pnfs_curr_ld->cleanup_layoutcommit)
+ nfss->pnfs_curr_ld->cleanup_layoutcommit(data);
+}
+
/*
* For the LAYOUT4_NFSV4_1_FILES layout type, NFS_DATA_SYNC WRITEs and
* NFS_UNSTABLE WRITEs with a COMMIT to data servers must store enough
diff --git a/fs/nfs/pnfs.h b/fs/nfs/pnfs.h
index bddd8b9..606fbde 100644
--- a/fs/nfs/pnfs.h
+++ b/fs/nfs/pnfs.h
@@ -113,6 +113,8 @@ struct pnfs_layoutdriver_type {
struct xdr_stream *xdr,
const struct nfs4_layoutreturn_args *args);
+ void (*cleanup_layoutcommit) (struct nfs4_layoutcommit_data *data);
+
void (*encode_layoutcommit) (struct pnfs_layout_hdr *layoutid,
struct xdr_stream *xdr,
const struct nfs4_layoutcommit_args *args);
@@ -196,6 +198,7 @@ void pnfs_roc_release(struct inode *ino);
void pnfs_roc_set_barrier(struct inode *ino, u32 barrier);
bool pnfs_roc_drain(struct inode *ino, u32 *barrier);
void pnfs_set_layoutcommit(struct nfs_write_data *wdata);
+void pnfs_cleanup_layoutcommit(struct nfs4_layoutcommit_data *data);
int pnfs_layoutcommit_inode(struct inode *inode, bool sync);
int _pnfs_return_layout(struct inode *);
int pnfs_ld_write_done(struct nfs_write_data *);
diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
index 94f27e5..569ea5b 100644
--- a/include/linux/nfs_xdr.h
+++ b/include/linux/nfs_xdr.h
@@ -269,6 +269,7 @@ struct nfs4_layoutcommit_res {
struct nfs_fattr *fattr;
const struct nfs_server *server;
struct nfs4_sequence_res seq_res;
+ int status;
};
struct nfs4_layoutcommit_data {
--
1.7.4.1
next prev parent reply other threads:[~2011-07-31 0:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 0:52 [PATCH v7 00/26] add block layout driver to pnfs client Jim Rees
2011-07-31 0:52 ` [PATCH v7 01/26] pnfs: save layoutcommit lwb at layout header Jim Rees
2011-07-31 0:52 ` [PATCH v7 02/26] pnfs: save layoutcommit cred at layout header init Jim Rees
2011-07-31 0:52 ` [PATCH v7 03/26] pnfs: let layoutcommit handle a list of lseg Jim Rees
2011-07-31 0:52 ` [PATCH v7 04/26] pnfs: use lwb as layoutcommit length Jim Rees
2011-07-31 0:52 ` [PATCH v7 05/26] pnfs: GETDEVICELIST Jim Rees
2011-07-31 0:52 ` [PATCH v7 06/26] pnfs: add set-clear layoutdriver interface Jim Rees
2011-07-31 0:52 ` [PATCH v7 07/26] pnfs: ask for layout_blksize and save it in nfs_server Jim Rees
2011-07-31 0:52 ` Jim Rees [this message]
2011-07-31 0:52 ` [PATCH v7 09/26] pnfsblock: add blocklayout Kconfig option, Makefile, and stubs Jim Rees
2011-07-31 0:52 ` [PATCH v7 10/26] pnfsblock: use pageio_ops api Jim Rees
2011-07-31 0:52 ` [PATCH v7 11/26] pnfsblock: basic extent code Jim Rees
2011-07-31 0:52 ` [PATCH v7 12/26] pnfsblock: add device operations Jim Rees
2011-09-13 15:14 ` Jeff Layton
2011-09-13 15:16 ` Jeff Layton
2011-09-13 15:49 ` Peng Tao
2011-07-31 0:52 ` [PATCH v7 13/26] pnfsblock: remove " Jim Rees
2011-07-31 0:52 ` [PATCH v7 14/26] pnfsblock: lseg alloc and free Jim Rees
2011-07-31 0:52 ` [PATCH v7 15/26] pnfsblock: merge extents Jim Rees
2011-07-31 0:52 ` [PATCH v7 16/26] pnfsblock: call and parse getdevicelist Jim Rees
2011-07-31 0:52 ` [PATCH v7 17/26] pnfsblock: xdr decode pnfs_block_layout4 Jim Rees
2011-07-31 0:52 ` [PATCH v7 18/26] pnfsblock: bl_find_get_extent Jim Rees
2011-07-31 0:52 ` [PATCH v7 19/26] pnfsblock: add extent manipulation functions Jim Rees
2011-07-31 0:52 ` [PATCH v7 20/26] pnfsblock: merge rw extents Jim Rees
2011-07-31 0:52 ` [PATCH v7 21/26] pnfsblock: encode_layoutcommit Jim Rees
2011-07-31 0:52 ` [PATCH v7 22/26] pnfsblock: cleanup_layoutcommit Jim Rees
2011-07-31 0:52 ` [PATCH v7 23/26] pnfsblock: bl_read_pagelist Jim Rees
2011-07-31 0:52 ` [PATCH v7 24/26] pnfsblock: bl_write_pagelist Jim Rees
2011-07-31 0:52 ` [PATCH v7 25/26] pnfsblock: note written INVAL areas for layoutcommit Jim Rees
2011-07-31 0:52 ` [PATCH v7 26/26] pnfsblock: write_pagelist handle zero invalid extents Jim Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312073576-11024-9-git-send-email-rees@umich.edu \
--to=rees@umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).