From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Please pull NFS client changes
Date: Sun, 31 Jul 2011 15:58:45 -0400 [thread overview]
Message-ID: <1312142325.7127.3.camel@lade.trondhjem.org> (raw)
In-Reply-To: <4E35B126.8050009@fusionio.com>
On Sun, 2011-07-31 at 21:46 +0200, Jens Axboe wrote:
> On 2011-07-31 21:39, Trond Myklebust wrote:
> > On Sun, 2011-07-31 at 21:14 +0200, Jens Axboe wrote:
> >> On 2011-07-31 20:24, Christoph Hellwig wrote:
> >>> How does this manage to include the pnfs block code, which only was posted
> >>> on the list a few hours before the pull request, and which doesn't
> >>> appear to past testing very well (although the major issue seems to be
> >>> core nfs code)?
> >>
> >> And it doesn't even compile:
> >>
> >> In file included from fs/nfs/client.c:51:0:
> >> fs/nfs/pnfs.h:384:1: error: expected identifier or ‘(’ before ‘{’ token
> >> fs/nfs/client.c: In function ‘nfs_server_set_fsinfo’:
> >> fs/nfs/client.c:939:8: error: ‘struct nfs_server’ has no member named
> >> ‘pnfs_blksize’
> >> fs/nfs/client.c: At top level:
> >> fs/nfs/pnfs.h:382:20: warning: ‘set_pnfs_layoutdriver’ used but never
> >> defined [enabled by default]
> >> make[2]: *** [fs/nfs/client.o] Error 1
> >
> > Sigh. This should fix it...
>
> Only the first one, there are two independent places it broke. You
> missed this bit:
>
> fs/nfs/client.c:939:8: error: ‘struct nfs_server’ has no member named
How's this?
8<--------------------------------------------------------------------------------------
next prev parent reply other threads:[~2011-07-31 19:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 3:19 Please pull NFS client changes Trond Myklebust
2011-07-31 18:24 ` Christoph Hellwig
2011-07-31 18:30 ` Myklebust, Trond
2011-07-31 19:14 ` Jens Axboe
2011-07-31 19:39 ` Trond Myklebust
2011-07-31 19:46 ` Jens Axboe
2011-07-31 19:58 ` Trond Myklebust [this message]
2011-07-31 20:03 ` Jens Axboe
2011-08-01 0:57 ` Stephen Rothwell
2011-08-01 1:01 ` Stephen Rothwell
2011-08-03 23:51 ` Boaz Harrosh
2011-08-03 23:54 ` Myklebust, Trond
2011-08-04 4:52 ` [PATCH] pnfs-obj: Fix the comp_index != 0 case Boaz Harrosh
2011-08-04 4:55 ` Boaz Harrosh
2011-08-04 4:54 ` [PATCH 1/2] pnfs-obj: Bug when we are running out of bio Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312142325.7127.3.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=hch@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).