From: Peng Tao <bergwolf@gmail.com>
To: Benny Halevy <benny@tonian.com>
Cc: linux-nfs@vger.kernel.org, Peng Tao <peng_tao@emc.com>
Subject: [PATCH 2/5] pNFS: recoalesce when ld read pagelist fails
Date: Sat, 6 Aug 2011 19:53:52 -0700 [thread overview]
Message-ID: <1312685635-1593-2-git-send-email-bergwolf@gmail.com> (raw)
In-Reply-To: <1312685635-1593-1-git-send-email-bergwolf@gmail.com>
For pnfs pagelist read failure, we need to pg_recoalesce and resend
IO to mds.
Signed-off-by: Peng Tao <peng_tao@emc.com>
---
fs/nfs/internal.h | 2 ++
fs/nfs/pnfs.c | 18 ++++++++++++++----
fs/nfs/read.c | 3 ++-
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index 62f183d..78b662e 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -307,6 +307,8 @@ extern int nfs_generic_flush(struct nfs_pageio_descriptor *desc,
struct list_head *head);
extern int do_nfs_writepage(struct page *page, struct writeback_control *wbc,
struct nfs_pageio_descriptor *pgio);
+extern void nfs_pageio_init_read_mds(struct nfs_pageio_descriptor *pgio,
+ struct inode *inode);
extern void nfs_pageio_init_write_mds(struct nfs_pageio_descriptor *pgio,
struct inode *inode, int ioflags);
extern void nfs_pageio_reset_write_mds(struct nfs_pageio_descriptor *pgio);
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 08aba45..66fc854 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1300,7 +1300,7 @@ EXPORT_SYMBOL_GPL(pnfs_generic_pg_writepages);
int
pnfs_ld_read_done(struct nfs_read_data *data)
{
- int status;
+ struct nfs_pageio_descriptor pgio;
if (!data->pnfs_error) {
__nfs4_read_done_cb(data);
@@ -1309,11 +1309,21 @@ pnfs_ld_read_done(struct nfs_read_data *data)
return 0;
}
+ put_lseg(data->lseg);
+ data->lseg = NULL;
dprintk("%s: pnfs_error=%d, retry via MDS\n", __func__,
data->pnfs_error);
- status = nfs_initiate_read(data, NFS_CLIENT(data->inode),
- data->mds_ops);
- return status ? : -EAGAIN;
+ nfs_pageio_init_read_mds(&pgio, data->inode);
+ pgio.pg_recoalesce = 1;
+ while (!list_empty(&data->pages)) {
+ struct nfs_page *req = nfs_list_entry(data->pages.next);
+
+ nfs_pageio_add_request(&pgio, req);
+ }
+ nfs_pageio_complete(&pgio);
+ nfs_readdata_release(data);
+
+ return 0;
}
EXPORT_SYMBOL_GPL(pnfs_ld_read_done);
diff --git a/fs/nfs/read.c b/fs/nfs/read.c
index 2171c04..2484131 100644
--- a/fs/nfs/read.c
+++ b/fs/nfs/read.c
@@ -112,12 +112,13 @@ static void nfs_readpage_truncate_uninitialised_page(struct nfs_read_data *data)
}
}
-static void nfs_pageio_init_read_mds(struct nfs_pageio_descriptor *pgio,
+void nfs_pageio_init_read_mds(struct nfs_pageio_descriptor *pgio,
struct inode *inode)
{
nfs_pageio_init(pgio, inode, &nfs_pageio_read_ops,
NFS_SERVER(inode)->rsize, 0);
}
+EXPORT_SYMBOL_GPL(nfs_pageio_init_read_mds);
void nfs_pageio_reset_read_mds(struct nfs_pageio_descriptor *pgio)
{
--
1.7.1.262.g5ef3d
next prev parent reply other threads:[~2011-08-10 15:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-07 2:53 [PATCH 1/5] pNFS: recoalesce when ld write pagelist fails Peng Tao
2011-08-07 2:53 ` Peng Tao [this message]
2011-08-10 17:55 ` [PATCH 2/5] pNFS: recoalesce when ld read " Boaz Harrosh
2011-08-11 0:01 ` Peng Tao
2011-08-07 2:53 ` [PATCH 3/5] pnfs: introduce pnfs private workqueue Peng Tao
2011-08-10 18:12 ` Boaz Harrosh
2011-08-10 18:21 ` Boaz Harrosh
2011-08-11 0:00 ` Peng Tao
2011-08-07 2:53 ` [PATCH 4/5] SUNRPC/NFS: make rpc pipe upcall generic Peng Tao
2011-08-10 15:59 ` Jim Rees
2011-08-07 2:53 ` [PATCH 5/5] pnfs: make _set_lo_fail generic Peng Tao
2011-08-10 17:52 ` [PATCH 1/5] pNFS: recoalesce when ld write pagelist fails Boaz Harrosh
2011-08-11 0:03 ` Peng Tao
2011-08-11 18:53 ` Boaz Harrosh
2011-08-11 23:53 ` Peng Tao
2011-08-12 0:10 ` Boaz Harrosh
2011-08-12 2:07 ` tao.peng
2011-08-16 7:20 ` tao.peng
2011-08-16 20:19 ` Boaz Harrosh
2011-08-17 9:44 ` Peng Tao
2011-08-22 23:28 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312685635-1593-2-git-send-email-bergwolf@gmail.com \
--to=bergwolf@gmail.com \
--cc=benny@tonian.com \
--cc=linux-nfs@vger.kernel.org \
--cc=peng_tao@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox