From: Jim Rees <rees@umich.edu>
To: Benny Halevy <bhalevy@tonian.com>
Cc: linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: [PATCH 1/3] pnfsblock: add missing rpc_put_mount and path_put
Date: Mon, 19 Sep 2011 23:18:46 -0400 [thread overview]
Message-ID: <1316488728-24912-2-git-send-email-rees@umich.edu> (raw)
In-Reply-To: <1316488728-24912-1-git-send-email-rees@umich.edu>
From: Peng Tao <bergwolf@gmail.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Peng Tao <peng_tao@emc.com>
Signed-off-by: Jim Rees <rees@umich.edu>
---
fs/nfs/blocklayout/blocklayout.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
index dc23833..dee6cae 100644
--- a/fs/nfs/blocklayout/blocklayout.c
+++ b/fs/nfs/blocklayout/blocklayout.c
@@ -993,17 +993,20 @@ static int __init nfs4blocklayout_init(void)
mnt,
NFS_PIPE_DIRNAME, 0, &path);
if (ret)
- goto out_remove;
+ goto out_putrpc;
bl_device_pipe = rpc_mkpipe(path.dentry, "blocklayout", NULL,
&bl_upcall_ops, 0);
+ path_put(&path);
if (IS_ERR(bl_device_pipe)) {
ret = PTR_ERR(bl_device_pipe);
- goto out_remove;
+ goto out_putrpc;
}
out:
return ret;
+out_putrpc:
+ rpc_put_mount();
out_remove:
pnfs_unregister_layoutdriver(&blocklayout_type);
return ret;
@@ -1016,6 +1019,7 @@ static void __exit nfs4blocklayout_exit(void)
pnfs_unregister_layoutdriver(&blocklayout_type);
rpc_unlink(bl_device_pipe);
+ rpc_put_mount();
}
MODULE_ALIAS("nfs-layouttype4-3");
--
1.7.4.1
next prev parent reply other threads:[~2011-09-20 3:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 3:18 [PATCH 0/3] replacement for "introduce pnfs private workqueue" Jim Rees
2011-09-20 3:18 ` Jim Rees [this message]
2011-09-20 3:18 ` [PATCH 2/3] pnfs: introduce pnfs private workqueue Jim Rees
2011-09-20 22:41 ` Trond Myklebust
2011-09-21 0:29 ` Jim Rees
2011-09-21 2:44 ` tao.peng
2011-09-21 4:20 ` Myklebust, Trond
2011-09-21 5:16 ` tao.peng
2011-09-21 7:04 ` Benny Halevy
2011-09-21 10:23 ` tao.peng
2011-09-21 10:38 ` Boaz Harrosh
2011-09-21 11:04 ` tao.peng
2011-09-21 10:56 ` Benny Halevy
2011-09-21 11:10 ` tao.peng
2011-09-21 11:27 ` Benny Halevy
2011-09-21 11:42 ` Boaz Harrosh
2011-09-21 11:50 ` Benny Halevy
2011-09-21 13:56 ` Boaz Harrosh
2011-09-21 15:45 ` Peng Tao
2011-09-21 16:03 ` Trond Myklebust
2011-09-22 3:30 ` tao.peng
2011-09-22 7:17 ` Boaz Harrosh
2011-09-21 4:22 ` Myklebust, Trond
2011-09-20 3:18 ` [PATCH 3/3] SQUASHME: pnfs: simplify and clean up pnfsiod workqueue Jim Rees
2011-09-21 11:52 ` [PATCH 0/3] replacement for "introduce pnfs private workqueue" Benny Halevy
2011-09-21 12:32 ` Jim Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316488728-24912-2-git-send-email-rees@umich.edu \
--to=rees@umich.edu \
--cc=bhalevy@tonian.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).