From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
miklos@szeredi.hu, Jeff Layton <jlayton@redhat.com>,
viro@zeniv.linux.org.uk, gregkh@suse.de,
linux-nfs@vger.kernel.org, leonardo.lists@gmail.com
Subject: Re: [PATCH] VFS: Suppress automount on [l]stat, [l]getxattr, etc.
Date: Fri, 23 Sep 2011 11:01:49 -0400 [thread overview]
Message-ID: <1316790109.14812.14.camel@lade.trondhjem.org> (raw)
In-Reply-To: <CA+55aFyd3QB-vfp9Vm6S6_YRCXO9pNE2YavYZhmO+5g6YfdERA@mail.gmail.com>
On Fri, 2011-09-23 at 07:46 -0700, Linus Torvalds wrote:
> On Fri, Sep 23, 2011 at 7:34 AM, Trond Myklebust
> <Trond.Myklebust@netapp.com> wrote:
> >
> > My objections are due to the other cases that I pointed out, where
> > Miklos's patch introduced changes in behaviour that IMO are unnecessary
> > and incorrect.
>
> Guys, it wasn't Mikos' patch that introduced the changes!
>
> What's so hard to understand here?
>
> That's why I'm so upset. People talk stupid sh*t about "correct
> behavior" when clearly no such thing *exists*. And people talk about
> Miklos changes as if they were some radical change that changed
> behavior, when they were only a revert to old behavior to begin with
> (at least as far as autofs is concerned)!
>
> Get a grip, people. Stop over-analyzing things. Stop bothering to
> mention what Solaris does, when the *MUCH* bigger issue is what
> *Linux* has done for years and years.
>
> Stop saying "we'll revert Miklos patch" in the same sentence where you
> then seem to not even understand that the *original* behavior was the
> one that Miklos patch re-introduced.
>
> Reverting Miklos patch isn't a revert. THAT is the "semantic change".
> That's the one you need to explain why the heck it would be the right
> thing to do, rather than imply that we'd be going back to some known
> state.
Wrong. Miklos's patch introduces new behaviour that was never present
previously:
- you can now bind mount to the hidden directory.
- you can quotactl the underlying directory.
As I said earlier: adding LOOKUP_DIRECTORY to those operations is not an
option because bind mount needs to work with files too (as long as the
source and target are both files). Ditto with quotactl.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
next prev parent reply other threads:[~2011-09-23 15:02 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 13:45 [PATCH] VFS: Suppress automount on [l]stat, [l]getxattr, etc David Howells
2011-09-22 14:33 ` Miklos Szeredi
2011-09-22 16:04 ` Ian Kent
2011-09-22 16:30 ` Linus Torvalds
2011-09-22 16:45 ` Ian Kent
2011-09-22 17:35 ` Jeff Layton
2011-09-22 18:44 ` Jeff Layton
2011-09-22 19:20 ` Trond Myklebust
2011-09-22 22:57 ` Linus Torvalds
2011-09-23 0:56 ` Myklebust, Trond
2011-09-23 1:04 ` Linus Torvalds
2011-09-23 1:21 ` Trond Myklebust
2011-09-23 7:25 ` Miklos Szeredi
2011-09-23 10:57 ` Ian Kent
2011-09-23 3:15 ` Ian Kent
2011-09-23 10:33 ` David Howells
2011-09-23 14:34 ` Trond Myklebust
2011-09-23 14:46 ` Linus Torvalds
2011-09-23 15:01 ` Trond Myklebust [this message]
2011-09-23 15:15 ` Linus Torvalds
2011-09-23 15:41 ` Ian Kent
2011-09-23 16:19 ` Miklos Szeredi
2011-09-23 16:21 ` Linus Torvalds
2011-09-23 16:26 ` Linus Torvalds
[not found] ` <13920.1316796007@redhat.com! >
2011-09-23 16:54 ` David Howells
2011-09-23 17:18 ` Linus Torvalds
2011-09-23 16:40 ` David Howells
2011-09-23 16:47 ` Linus Torvalds
2011-09-23 15:18 ` David Howells
2011-09-23 16:10 ` Miklos Szeredi
2011-09-24 1:30 ` Ian Kent
2011-09-24 1:44 ` Linus Torvalds
2011-09-24 2:31 ` Ian Kent
2011-09-24 11:36 ` Jeff Layton
2011-09-24 15:56 ` Linus Torvalds
2011-09-26 5:11 ` Ian Kent
2011-09-26 20:48 ` Linus Torvalds
2011-09-26 21:13 ` Trond Myklebust
2011-09-26 21:24 ` Linus Torvalds
2011-09-26 21:31 ` Trond Myklebust
2011-09-26 22:24 ` Linus Torvalds
2011-09-26 22:33 ` Trond Myklebust
2011-09-26 22:56 ` Linus Torvalds
2011-09-26 23:09 ` Trond Myklebust
2011-09-26 23:26 ` Linus Torvalds
2011-09-27 0:59 ` Trond Myklebust
2011-09-27 1:18 ` Linus Torvalds
2011-09-27 4:24 ` Ian Kent
2011-09-27 3:57 ` Linus Torvalds
2011-09-27 4:16 ` Ian Kent
2011-09-27 4:35 ` Linus Torvalds
2011-09-27 4:51 ` Ian Kent
2011-09-27 14:32 ` Linus Torvalds
2011-09-27 15:11 ` Myklebust, Trond
2011-09-29 9:32 ` Ian Kent
2011-09-27 15:22 ` Linus Torvalds
2011-09-27 17:38 ` Greg KH
2011-09-27 17:51 ` Linus Torvalds
2011-09-27 18:00 ` Greg KH
2011-09-27 20:18 ` Miklos Szeredi
2011-09-27 22:38 ` Greg KH
2011-09-27 13:34 ` [PATCH 1/2] VFS: Fix the remaining automounter semantics regressions Trond Myklebust
2011-09-27 13:34 ` [PATCH 2/2] VFS: Document automounter semantics Trond Myklebust
2011-09-23 15:23 ` [PATCH] VFS: Suppress automount on [l]stat, [l]getxattr, etc David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316790109.14812.14.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=jlayton@redhat.com \
--cc=leonardo.lists@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).