From: andros@netapp.com
To: trond.myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org,
Andy Adamson <andros@fedora-64.andros.fake>,
Andy Adamson <andros@netapp.com>
Subject: [PATCH Version 2 3/3] NFSv4.1: fix backchennel bug
Date: Tue, 18 Oct 2011 02:33:07 -0400 [thread overview]
Message-ID: <1318919587-2642-3-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1318919587-2642-1-git-send-email-andros@netapp.com>
From: Andy Adamson <andros@fedora-64.andros.fake>
Slotid's start from 0 which means we check against
NFS41_BC_MAX_CALLBACKS - 1.
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfs/callback_proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c
index 98ff5fc..12bd9d0 100644
--- a/fs/nfs/callback_proc.c
+++ b/fs/nfs/callback_proc.c
@@ -339,7 +339,7 @@ validate_seqid(struct nfs4_slot_table *tbl, struct cb_sequenceargs * args)
dprintk("%s enter. slotid %d seqid %d\n",
__func__, args->csa_slotid, args->csa_sequenceid);
- if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS)
+ if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS - 1)
return htonl(NFS4ERR_BADSLOT);
slot = nfs4_lookup_slot_locked(tbl, args->csa_slotid);
--
1.7.5.1
prev parent reply other threads:[~2011-11-04 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 6:33 [PATCH Version 2 1/3] NFSv4.1: dynamic session slots andros
2011-10-18 6:33 ` [PATCH Version 2 2/3] NFSv4.1: rename nfs4_free_slot and nfs4_find_slot andros
2011-10-18 6:33 ` andros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318919587-2642-3-git-send-email-andros@netapp.com \
--to=andros@netapp.com \
--cc=andros@fedora-64.andros.fake \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).