* [PATCH] nfsd4: typo logical vs bitwise negate in nfsd4_decode_share_access
@ 2011-10-27 18:43 Benny Halevy
2011-10-28 10:02 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Benny Halevy @ 2011-10-27 18:43 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs, Benny Halevy
From: Benny Halevy <bhalevy@tonian.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 66d095d..b6fa792 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -655,7 +655,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
default:
return nfserr_bad_xdr;
}
- w &= !NFS4_SHARE_ACCESS_MASK;
+ w &= ~NFS4_SHARE_ACCESS_MASK;
if (!w)
return nfs_ok;
if (!argp->minorversion)
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd4: typo logical vs bitwise negate in nfsd4_decode_share_access
2011-10-27 18:43 [PATCH] nfsd4: typo logical vs bitwise negate in nfsd4_decode_share_access Benny Halevy
@ 2011-10-28 10:02 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2011-10-28 10:02 UTC (permalink / raw)
To: Benny Halevy; +Cc: bfields, linux-nfs, Benny Halevy
Oh cripes, another one. Thanks for catching this one too.
--b.
On Thu, Oct 27, 2011 at 08:43:01PM +0200, Benny Halevy wrote:
> From: Benny Halevy <bhalevy@tonian.com>
>
> Signed-off-by: Benny Halevy <bhalevy@tonian.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 66d095d..b6fa792 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -655,7 +655,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
> default:
> return nfserr_bad_xdr;
> }
> - w &= !NFS4_SHARE_ACCESS_MASK;
> + w &= ~NFS4_SHARE_ACCESS_MASK;
> if (!w)
> return nfs_ok;
> if (!argp->minorversion)
> --
> 1.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-28 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-27 18:43 [PATCH] nfsd4: typo logical vs bitwise negate in nfsd4_decode_share_access Benny Halevy
2011-10-28 10:02 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).