From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 2/2] nfsidmap: Added -v flag
Date: Thu, 10 Nov 2011 15:26:25 -0500 [thread overview]
Message-ID: <1320956785-18004-3-git-send-email-steved@redhat.com> (raw)
In-Reply-To: <1320956785-18004-1-git-send-email-steved@redhat.com>
To aid in debugging, the -v flag can now be specified
on the command to enable verbose logging in both
the nfsidmap command and libnfsidmap library routines.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/nfsidmap/nfsidmap.c | 12 ++++++++++++
utils/nfsidmap/nfsidmap.man | 15 ++++++++++++---
2 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/utils/nfsidmap/nfsidmap.c b/utils/nfsidmap/nfsidmap.c
index 134d9bc..d74189a 100644
--- a/utils/nfsidmap/nfsidmap.c
+++ b/utils/nfsidmap/nfsidmap.c
@@ -12,6 +12,7 @@
#include <syslog.h>
#include "xlog.h"
+int verbose = 0;
/* gcc nfsidmap.c -o nfsidmap -l nfsidmap -l keyutils */
#define MAX_ID_LEN 11
@@ -108,6 +109,12 @@ int main(int argc, char **argv)
xlog_syslog(1);
xlog_stderr(0);
+ if (argc > 1 && strcmp(argv[1], "-v") == 0) {
+ verbose = 1;
+ nfs4_set_debug(1, NULL);
+ argc--, argv++;
+ }
+
if (argc < 3) {
xlog_err("Bad arg count. Check /etc/request-key.conf");
return 1;
@@ -126,6 +133,11 @@ int main(int argc, char **argv)
key = strtol(argv[1], NULL, 10);
+ if (verbose) {
+ xlog_warn("key: %ld type: %s value: %s timeout %ld",
+ key, type, value, timeout);
+ }
+
if (strcmp(type, "uid") == 0)
rc = id_lookup(value, key, USER);
else if (strcmp(type, "gid") == 0)
diff --git a/utils/nfsidmap/nfsidmap.man b/utils/nfsidmap/nfsidmap.man
index 2381908..aa4d94b 100644
--- a/utils/nfsidmap/nfsidmap.man
+++ b/utils/nfsidmap/nfsidmap.man
@@ -5,6 +5,8 @@
.TH nfsidmap 5 "1 October 2010"
.SH NAME
nfsidmap \- The NFS idmapper upcall program
+.SH SYNOPSIS
+.B "nfsidmap [-v] key user [timeout]"
.SH DESCRIPTION
The file
.I /usr/sbin/nfsidmap
@@ -14,9 +16,16 @@ the upcall and cache the result.
.I /usr/sbin/nfsidmap
should only be called by request-key, and will perform the translation and
initialize a key with the resulting information.
-.PP
-NFS_USE_NEW_IDMAPPER must be selected when configuring the kernel to use this
-feature.
+.SH OPTIONS
+.TP
+.B -v
+Enables verbose logging in both the
+.B nfsidmap
+binary and in the library routines
+that are used.
+.B Note,
+the -v flag has to be the first argument on the
+command to enable the logging.
.SH CONFIGURING
The file
.I /etc/request-key.conf
--
1.7.6.4
next prev parent reply other threads:[~2011-11-10 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 20:26 [PATCH 0/2] nfsidmap: Added error logging and verbosity flag Steve Dickson
2011-11-10 20:26 ` [PATCH 1/2] nfsidmap: Added Error Logging Steve Dickson
2011-11-10 20:26 ` Steve Dickson [this message]
2011-11-10 21:11 ` [PATCH 2/2] nfsidmap: Added -v flag Jim Rees
2011-11-10 21:25 ` Steve Dickson
2011-11-11 0:23 ` Jim Rees
2011-11-11 14:55 ` Steve Dickson
2011-11-10 21:19 ` Bryan Schumaker
2011-11-10 21:27 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320956785-18004-3-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox