linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: rjw@sisk.pl
Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-pm@vger.kernel.org, tj@kernel.org, john@calva.com,
	trond.myklebust@netapp.com, marek.belisko@gmail.com,
	awilliam@redhat.com
Subject: [PATCH v3 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight
Date: Mon, 28 Nov 2011 15:01:26 -0500	[thread overview]
Message-ID: <1322510488-21189-1-git-send-email-jlayton@redhat.com> (raw)

This patchset is a second (third?) attempt at fixing the issues with
suspending a machine that has an active NFS mount.

The bug reported against Fedora is here:

    https://bugzilla.redhat.com/show_bug.cgi?id=717735

The main difference between v2 and this one is that this one has the new
macros attempt to freeze before going to sleep. It's possible for the
freezer_do_not_count() call to race with the freezer. The FREEZER_SKIP
flag can be set after the freezer has already attempted to freeze the
task. If so, it may just go to sleep without attempting to freeze.

This set attempts to remedy this by calling try_to_freeze() after
calling freezer_do_not_count() and before sleeping. This should prevent
the above race.

I've also fleshed out the comments a bit to nail down the semantics for
these new functions. I'm quite open to changing the names of the
functions as well, if anyone can suggest better alternatives.

Comments and more tested would be appreciated. My goal is to get this
in for 3.3, hopefully via Rafael's tree.

Jeff Layton (2):
  sunrpc: make rpc_wait_bit_killable handle freeze events
  nfs: make TASK_KILLABLE sleeps attempt to freeze

 fs/nfs/inode.c          |    3 ++-
 fs/nfs/nfs3proc.c       |    3 ++-
 fs/nfs/nfs4proc.c       |    5 +++--
 fs/nfs/proc.c           |    3 ++-
 include/linux/freezer.h |   40 ++++++++++++++++++++++++++++++++++++++++
 net/sunrpc/sched.c      |    3 ++-
 6 files changed, 51 insertions(+), 6 deletions(-)

-- 
1.7.6.4


             reply	other threads:[~2011-11-28 20:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 20:01 Jeff Layton [this message]
2011-11-28 20:01 ` [PATCH v3 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
2011-11-28 20:39   ` Tejun Heo
2011-11-28 20:01 ` [PATCH v3 2/2] nfs: make TASK_KILLABLE sleeps attempt to freeze Jeff Layton
2011-11-28 20:22 ` [PATCH v3 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Rafael J. Wysocki
2011-11-28 20:40   ` Tejun Heo
2011-11-28 21:07     ` Rafael J. Wysocki
2011-11-28 21:09       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322510488-21189-1-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=awilliam@redhat.com \
    --cc=john@calva.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    --cc=rjw@sisk.pl \
    --cc=tj@kernel.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).