linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@tonian.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Michal Marek <mmarek@suse.cz>,
	NFS list <linux-nfs@vger.kernel.org>,
	open-osd <osd-dev@open-osd.org>
Subject: Re: ore: FIX breakage when MISC_FILESYSTEMS is not set
Date: Tue, 29 Nov 2011 17:36:33 -0500	[thread overview]
Message-ID: <1322606193.11286.28.camel@lade.trondhjem.org> (raw)
In-Reply-To: <4ED55B3B.9050207@panasas.com>

On Tue, 2011-11-29 at 14:22 -0800, Boaz Harrosh wrote: 
> On 11/29/2011 09:33 AM, Trond Myklebust wrote:
> > On Tue, 2011-11-29 at 14:21 +0200, Benny Halevy wrote: 
> >> On 2011-11-29 02:13, Boaz Harrosh wrote:
> 
> >>>
> >>> The solution is to force all users of ORE (exofs, nfs) to manually
> >>> select everything auto-magically selected before.
> >>
> >> How about using "depend ORE" rather than "select ORE"?
> > 
> > Right. Make PNFS_OBJLAYOUT and EXOFS_FS depend on ASYNC_XOR (or select
> > it) and then make ORE depend on EXOFS_FS || PNFS_OBJLAYOUT.
> > 
> > There should be no need to add the 'select ORE'...
> > 
> 
> No! guys!
> 
> One it will not solve my problem because any
> solution that needs to inspect exofs/Kconfig file will
> not work if MISC_FILESYSTEMS is not selected and your
> solutions involve that.

Then move ORE _out_ of MISC_FILESYSTEMS. There is no reason why it needs
to be there as long as the things it depends on are there.

> And two:
> All the user needs to do is Select NFS4.1 everything
> else should be done automatically. He should not need
> to go to misc-filesystems and select ORE so he can have
> pnfs-objects. That's a nightmare.

The solution I proposed didn't involve having the user select anything
other than NFSv4.1 and possibly ASYNC_XOR.

> And anyway the current Kernel rule is that a user of a library
> needs to select it and all it's dependencies, because select
> is not recursive. Now I devised a little skim that can avoid

...and this is _my_ nightmare. I dont' _want_ these selects anywhere in
the NFS subsystem.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


  reply	other threads:[~2011-11-29 22:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111124174358.d88f11c0ff700e5e6b3bf73b@canb.auug.org.au>
     [not found] ` <4ECE91F3.9010007@xenotime.net>
     [not found]   ` <4ED422CC.60706@panasas.com>
2011-11-29  0:13     ` ore: FIX breakage when MISC_FILESYSTEMS is not set Boaz Harrosh
2011-11-29 12:21       ` Benny Halevy
2011-11-29 17:33         ` Trond Myklebust
2011-11-29 22:22           ` Boaz Harrosh
2011-11-29 22:36             ` Trond Myklebust [this message]
2011-11-29 22:38               ` Trond Myklebust
2011-11-29 23:33                 ` Boaz Harrosh
2011-11-29 23:39             ` Randy Dunlap
2011-11-29 23:30               ` Boaz Harrosh
2011-11-29 23:35       ` [PATCH v3] " Boaz Harrosh
2011-11-30  1:00         ` [osd-dev] " Boaz Harrosh
2011-11-30 18:00           ` Randy Dunlap
2011-11-30  8:31         ` Michal Marek
2011-11-30 16:32           ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322606193.11286.28.camel@lade.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=bhalevy@tonian.com \
    --cc=bharrosh@panasas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=osd-dev@open-osd.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).