From: Benny Halevy <benny@tonian.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 07/10] ctl: fix compiler warnings
Date: Mon, 5 Dec 2011 10:14:01 +0200 [thread overview]
Message-ID: <1323072841-18376-1-git-send-email-benny@tonian.com> (raw)
In-Reply-To: <4EDC7C4E.1040901@tonian.com>
From: Benny Halevy <bhalevy@tonian.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
---
ctl.c | 20 +++++++++-----------
1 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/ctl.c b/ctl.c
index d989ab8..e5d16e3 100644
--- a/ctl.c
+++ b/ctl.c
@@ -75,11 +75,10 @@ struct event ge;
int
main(int argc, char **argv)
{
- int upcall_fd,
- operation = -1,
- len;
- char c,
- *prog;
+ int upcall_fd;
+ int operation = -1;
+ char c;
+ char *prog;
pthread_t t;
void *thr_val;
@@ -162,7 +161,7 @@ process_msg(int fd, short ev_type, void *arg)
return;
len = sizeof (bl_comm_res_t);
if ((cc = read(fd, &msg, sizeof (msg))) != sizeof (msg)) {
- printf("Failed to get all of message. Got %d, expected %d\n",
+ printf("Failed to get all of message. Got %d, expected %Zd\n",
cc, sizeof (msg));
resp->res_status = PNFS_BLOCK_FAILURE;
write(fd, resp, len);
@@ -352,9 +351,7 @@ get_dm(bl_comm_msg_t *msg, bl_comm_res_t *res, int *lenp)
bl_comm_res_t *
check_dm(bl_comm_msg_t *msg, bl_comm_res_t *res, int *len)
{
- int fd,
- major,
- minor;
+ int major, minor;
char *name;
res->res_status = PNFS_BLOCK_SUCCESS;
@@ -391,7 +388,7 @@ get_slice(bl_comm_msg_t *msg, bl_comm_res_t *res, int *len)
partition = minor & 0xf;
res->res_status = PNFS_BLOCK_FAILURE; // Default condition
- printf("%s: %u:%u: ", __func__, major, minor); fflush(stdout);
+ printf("%s: %u:%u: ", __func__, (unsigned)major, (unsigned)minor); fflush(stdout);
if (mknod(path, S_IFBLK | 0600, dev)) {
perror("mknod");
@@ -421,7 +418,8 @@ get_slice(bl_comm_msg_t *msg, bl_comm_res_t *res, int *len)
res->res_status = PNFS_BLOCK_SUCCESS;
res->u.slice.start = ppart->geom.start;
res->u.slice.length = ppart->geom.length;
- printf("Dev: %d:%d, Start: %llu, Length: %llu\n", major, minor,
+ printf("Dev: %u:%u, Start: %llu, Length: %llu\n",
+ (unsigned)major, (unsigned)minor,
res->u.slice.start, res->u.slice.length);
out:
(void) unlink(path);
--
1.7.6
next prev parent reply other threads:[~2011-12-05 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 8:09 [PATCH 0/10] pnfs-block ctl Benny Halevy
2011-12-05 8:12 ` [PATCH 01/10] use gcc Benny Halevy
2011-12-05 8:13 ` [PATCH 02/10] efi: fix user-land debug printouts Benny Halevy
2011-12-05 8:13 ` [PATCH 03/10] ctl: improve " Benny Halevy
2011-12-05 8:13 ` [PATCH 04/10] increase compiler warning level Benny Halevy
2011-12-05 8:13 ` [PATCH 05/10] ctl: always return a value from find_dm_name Benny Halevy
2011-12-05 8:13 ` [PATCH 06/10] add missing includes Benny Halevy
2011-12-05 8:14 ` Benny Halevy [this message]
2011-12-05 8:14 ` [PATCH 08/10] fix compiler warnings around get_output use of argv Benny Halevy
2011-12-05 8:14 ` [PATCH 09/10] ctl: main should return 0 on success Benny Halevy
2011-12-05 8:14 ` [PATCH 10/10] efi: fix compiler warnings Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323072841-18376-1-git-send-email-benny@tonian.com \
--to=benny@tonian.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).