linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Gundersen <teg@jklm.no>
To: linux-nfs@vger.kernel.org
Cc: Tom Gundersen <teg@jklm.no>, Kay Sievers <kay.sievers@vrfy.org>
Subject: [RFC][PATCH] libtirpc,rpcbind: move socket from /var/run to /run
Date: Thu,  8 Dec 2011 20:19:00 +0100	[thread overview]
Message-ID: <1323371940-9140-1-git-send-email-teg@jklm.no> (raw)

/run is guaranteed to be available and writeable at any time, whereas
/var might be on a separate partition and hence not available during
early boot. By moving the socket from /var to /run we are able to use
rpcbind earlier, which would in particular make a difference in case
/var is on an nfs mount, something I am currently seeing bug reports
about.

This change should not make a difference to software that currently
works as intended, as /var/run should be a symlink or bindmounted
to /run, so anyone relying on the socket being in /var/run will
still find it there.

The /run directory is supported by all the major distributions
(at least Debian, Fedora, Suse, Ubuntu and Arch from what I can gather).
See http://wiki.debian.org/ReleaseGoals/RunDirectory and
http://thread.gmane.org/gmane.linux.redhat.fedora.devel/146976 for some
more details.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Tom Gundersen <teg@jklm.no>
---
 tirpc/rpc/rpcb_prot.h |    2 +-
 tirpc/rpc/rpcb_prot.x |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tirpc/rpc/rpcb_prot.h b/tirpc/rpc/rpcb_prot.h
index 7ae48b8..63b4a2c 100644
--- a/tirpc/rpc/rpcb_prot.h
+++ b/tirpc/rpc/rpcb_prot.h
@@ -476,7 +476,7 @@ extern bool_t xdr_netbuf(XDR *, struct netbuf *);
 #define RPCBVERS_3 RPCBVERS
 #define RPCBVERS_4 RPCBVERS4
 
-#define _PATH_RPCBINDSOCK "/var/run/rpcbind.sock"
+#define _PATH_RPCBINDSOCK "/run/rpcbind.sock"
 
 #else /* ndef _KERNEL */
 #ifdef __cplusplus
diff --git a/tirpc/rpc/rpcb_prot.x b/tirpc/rpc/rpcb_prot.x
index b21ac3d..ebe1e60 100644
--- a/tirpc/rpc/rpcb_prot.x
+++ b/tirpc/rpc/rpcb_prot.x
@@ -410,7 +410,7 @@ program RPCBPROG {
 %#define	RPCBVERS_3		RPCBVERS
 %#define	RPCBVERS_4		RPCBVERS4
 %
-%#define	_PATH_RPCBINDSOCK	"/var/run/rpcbind.sock"
+%#define	_PATH_RPCBINDSOCK	"/run/rpcbind.sock"
 %
 %#else		/* ndef _KERNEL */
 %#ifdef __cplusplus
-- 
1.7.8


             reply	other threads:[~2011-12-08 19:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 19:19 Tom Gundersen [this message]
2011-12-08 21:40 ` [RFC][PATCH] libtirpc,rpcbind: move socket from /var/run to /run Chuck Lever
2011-12-08 23:05   ` Tom Gundersen
2011-12-08 23:11     ` Chuck Lever
2011-12-08 23:40 ` Rüdiger Meier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323371940-9140-1-git-send-email-teg@jklm.no \
    --to=teg@jklm.no \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).