linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] NFSv4: Save the owner/group name string when doing open
Date: Sun, 08 Jan 2012 12:20:37 -0500	[thread overview]
Message-ID: <1326043237.2935.0.camel@lade.trondhjem.org> (raw)
In-Reply-To: <23AF1B91-F3FF-4B9F-AAE3-A9DDB4ED205A@oracle.com>

On Sat, 2012-01-07 at 18:13 -0500, Chuck Lever wrote: 
> On Jan 7, 2012, at 1:27 PM, Trond Myklebust wrote:
> 
> > ...so that we can do the uid/gid mapping outside the asynchronous RPC
> > context.
> > This fixes a bug in the current NFSv4 atomic open code where the client
> > isn't able to determine what the true uid/gid fields of the file are,
> > (because the asynchronous nature of the OPEN call denies it the ability
> > to do an upcall) and so fills them with default values, marking the
> > inode as needing revalidation.
> > Unfortunately, in some cases, the VFS will do some additional sanity
> > checks on the file, and may override the server's decision to allow
> > the open because it sees the wrong owner/group fields.
> 
> I expect this change would also address the known problem with empty application core dumps on NFSv4 mounts...?

Yes. I believe that the above mentioned VFS-level checks were the
problem there.


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com


  reply	other threads:[~2012-01-08 17:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 17:08 [PATCH] NFSv4: Save the owner/group name string when doing open Trond Myklebust
2012-01-07 18:27 ` [PATCH v2] " Trond Myklebust
2012-01-07 23:13   ` Chuck Lever
2012-01-08 17:20     ` Trond Myklebust [this message]
2012-03-02  5:08   ` Jonathan Nieder
2012-05-10  0:18     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326043237.2935.0.camel@lade.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).